Re: [Beignet] [PATCH V2] backend: add global immediate optimization

2017-06-13 Thread Wang, Rander
Ok, I will refine my patch according to discussing Thank you! -Original Message- From: Song, Ruiling Sent: Tuesday, June 13, 2017 3:21 PM To: Wang, Rander <rander.w...@intel.com>; beig...@freedesktop.org Subject: RE: [Beignet] [PATCH V2] backend: add global immediate optimi

Re: [Beignet] [PATCH V2] backend: add global immediate optimization

2017-06-13 Thread Song, Ruiling
> -Original Message- > From: Wang, Rander > Sent: Tuesday, June 13, 2017 1:24 PM > To: Song, Ruiling <ruiling.s...@intel.com>; beig...@freedesktop.org > Subject: RE: [Beignet] [PATCH V2] backend: add global immediate optimization > > > > -O

Re: [Beignet] [PATCH V2] backend: add global immediate optimization

2017-06-12 Thread Wang, Rander
-Original Message- From: Song, Ruiling Sent: Tuesday, June 13, 2017 10:24 AM To: Wang, Rander <rander.w...@intel.com>; beig...@freedesktop.org Cc: Wang, Rander <rander.w...@intel.com> Subject: RE: [Beignet] [PATCH V2] backend: add global immediate optimization >

Re: [Beignet] [PATCH V2] backend: add global immediate optimization

2017-06-12 Thread Song, Ruiling
> + else if (src0.type == GEN_TYPE_D || src0.type == GEN_TYPE_UD) > + { > +int s0 = src0.value.d; > +if (src0.absolute) > + s0 = fabs(s0); Here I think it should be abs(s0), right? > +if (src0.negation) > + s0 = -s0;

[Beignet] [PATCH V2] backend: add global immediate optimization

2017-06-11 Thread rander.wang
there are some global immediates in global var list of LLVM. these imm can be integrated in instructions. for compiler_global_immediate_optimized test in utest, there are two global immediates: L0: MOV(1) %42<0>:UD : 0x0:UD