[Bf-blender-cvs] [38031a4a24d] modifier-panels-ui: Fix (unreported) crash on use-after-free in liboverride deletion code.

[Bastien Montagne]

Commit: 38031a4a24daea1607d6271fc39621a11aa4ef84
Author: Bastien Montagne
Date:   Thu Apr 16 12:24:21 2020 +0200
Branches: modifier-panels-ui
https://developer.blender.org/rB38031a4a24daea1607d6271fc39621a11aa4ef84

Fix (unreported) crash on use-after-free in liboverride deletion code.

===================================================================

M       source/blender/blenkernel/intern/lib_override.c

===================================================================

diff --git a/source/blender/blenkernel/intern/lib_override.c 
b/source/blender/blenkernel/intern/lib_override.c
index 6a206fc46d9..e6a792bc58a 100644
--- a/source/blender/blenkernel/intern/lib_override.c
+++ b/source/blender/blenkernel/intern/lib_override.c
@@ -383,10 +383,10 @@ void 
lib_override_library_property_clear(IDOverrideLibraryProperty *op)
 void BKE_lib_override_library_property_delete(IDOverrideLibrary *override,
                                               IDOverrideLibraryProperty 
*override_property)
 {
-  lib_override_library_property_clear(override_property);
   if (override->runtime != NULL) {
     BLI_ghash_remove(override->runtime, override_property->rna_path, NULL, 
NULL);
   }
+  lib_override_library_property_clear(override_property);
   BLI_freelinkN(&override->properties, override_property);
 }

_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
https://lists.blender.org/mailman/listinfo/bf-blender-cvs