Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [53534] trunk/blender/build_files: Patch from Ejner Fergo: enhancements to install_deps.sh.

2013-01-11 Thread Ejner Fergo
Hi again, I got RPM to compile with scons, by adding 'rt' in this scons config option: LLIBS = ['util', 'c', 'm', 'dl', 'pthread', 'stdc++', 'rt' ] I also forgot to mention yesterday another caveat compiling with scons: No OSL or OpenCOLLADA... couldn't get them to work :-/ Compiling with cmake

[Bf-committers] Color Correction Node - Lift

2013-01-11 Thread Bartek Skorupa (priv)
I'd like to point out that in Color Correction node we have some naming issues. Lift in all of the color correction tools do as follows: C - input value L - lift value R - resulting value R = (1-C) * L + C in Color Correction node Lift simply adds lift value to input color. I think we need to

Re: [Bf-committers] Color Correction Node - Lift

2013-01-11 Thread Bartek Skorupa (priv)
Sorry for double message on the same topic: When analyzing behavior of Color Correction node I noticed that in fact all of the terms are messed up here. It seems that this node uses Offset/Gamma/Slope model. Therefore Gain also doesn't do what it says. What it does is SLOPE, not GAIN. Bartek

Re: [Bf-committers] Color Correction Node - Lift

2013-01-11 Thread Troy Sobotka
On Jan 11, 2013 7:27 AM, Bartek Skorupa (priv) bartekskor...@bartekskorupa.com wrote: R = (1-C) * L + C I don't believe this would work well at all with scene referred models / spaces, of which Blender is. Perhaps it is wiser to shift the default operation to ASC CDL format? With respect,

Re: [Bf-committers] Color Correction Node - Lift

2013-01-11 Thread Bartek Skorupa (priv)
I'd prefer it working like LIFT/GAMMA/GAIN does, but this is my personal taste. In my opinion ASC CDL is rather not practical for working with colors. It's great to exchange grades between apps, but I simply don't feel it when grading. The way Color Correction node works now is neither

Re: [Bf-committers] Color Correction Node - Lift

2013-01-11 Thread Troy Sobotka
On Jan 11, 2013 10:31 AM, Bartek Skorupa (priv) bartekskor...@bartekskorupa.com wrote: I'd prefer it working like LIFT/GAMMA/GAIN does, but this is my personal taste. You missed my point. The formula does not work on scene referred data. With respect, TJS

[Bf-committers] Compile Failure since 53730?

2013-01-11 Thread Harley Acheson
Hello, Getting errors compiling (scons VS9) since 53730 with errors in editmesh_knife.c. Compiles fine if I revert that one change. Harley source\blender\editors\mesh\editmesh_knife.c(228) : error C2054: expected '(' to follow 'inline' source\blender\editors\mesh\editmesh_knife.c(229) :

Re: [Bf-committers] Compile Failure since 53730?

2013-01-11 Thread Dominik Maier
Hello Harley, the problem is that in the c standart library of msvc inline is defined as __inline. If you add these two underscores it works. This is specific to msvc, it works on the gnu c compiler without the underscores (also on MinGW). Also for the msvc c++ compiler inline without underscores