Re: [Bf-committers] [PATCH] Patch to storage.c to avoid crash on long userids

2010-03-29 Thread Rob M
Hi, The patch is bad style. You should not pass literal sizes to strncpy - what happens when someone changes the size of the array? Passing sizeof(files[num].owner) is better (but doesn't allow easy translation from 8bit chars to wide chars). Would it not also be better to increase the size of the

Re: [Bf-committers] Preference file changes for Vista/Win7, network installations, and large domain deployments

2010-03-30 Thread Rob M
Hi Harley, You might also want to look at fixing the problems with using UNC paths in blender. I've reported a few bugs in this area and they've all been closed because they're not considered bugs! Eg see http://projects.blender.org/tracker/?func=detail&atid=498&aid=21833&group_id =9 Rob. > ---

Re: [Bf-committers] Preference file changes for Vista/Win7, network installations, and large domain deployments

2010-03-30 Thread Rob M
s? Regards, Rob. > -Original Message- > From: bf-committers-boun...@blender.org [mailto:bf-committers- > boun...@blender.org] On Behalf Of Rob M > Sent: Tuesday, March 30, 2010 12:08 PM > To: 'bf-blender developers' > Subject: Re: [Bf-committers] Pref

[Bf-committers] (no subject)

2010-04-07 Thread Rob M
Hi, I've updated my patch for the UNC path problem which allow Blender to run from and use UNC paths. See http://projects.blender.org/tracker/index.php?func=detail&aid=21836&group_id =9&atid=127 Is there any point / need to back porting this to 2.49? Regards, Rob. __

Re: [Bf-committers] International Input

2010-04-22 Thread Rob M
> > 1. use platform specific unicode version of file operation API in the > > implementation of BLI_fileops and encode the (probably) wchar > > filename into utf8. > > For Windows file operations we need to change “winstuff” to use > FindFirstFileW > and FindNextFileW instead of the ansi versions.

Re: [Bf-committers] Support displaying of non-ASCII filename

2010-04-27 Thread Rob M
Hi, I don't think it will work. As I discovered when developing the patch "[#21836] There are problems running blender using UNC paths" there are more places where blender uses file and path names than just winstuff.c and they are not wide character or even utf-8 compatible. IMHO A better sol

Re: [Bf-committers] Installation/file paths

2010-05-11 Thread Rob M
> -Original Message- > From: bf-committers-boun...@blender.org [mailto:bf-committers- > boun...@blender.org] On Behalf Of Matt Ebb > Sent: Tuesday, May 11, 2010 9:17 AM > To: Bf-committers@blender.org > Subject: [Bf-committers] Installation/file paths > > Hi, > > My main task this week is