Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [40677] trunk/blender/source/blender/ editors/animation/anim_filter.c: Reverting part of r.40659

2011-09-28 Thread Matt Ebb
On Thu, Sep 29, 2011 at 9:43 AM, Joshua Leung wrote: > Reverting part of r.40659 > > The output of an automated tool is not a valid excuse for clobbering > code to increase maintenance headaches later on. > It might be a good idea to reiterate for new developers: Please avoid committing in other

Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [40677] trunk/blender/source/blender/ editors/animation/anim_filter.c: Reverting part of r.40659

2011-09-28 Thread Daniel Salazar - 3Developer.com
+1 Daniel Salazar 3Developer.com On Wed, Sep 28, 2011 at 6:09 PM, Matt Ebb wrote: > On Thu, Sep 29, 2011 at 9:43 AM, Joshua Leung wrote: > >> Reverting part of r.40659 >> >> The output of an automated tool is not a valid excuse for clobbering >> code to increase maintenance headaches later on.

Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [40677] trunk/blender/source/blender/ editors/animation/anim_filter.c: Reverting part of r.40659

2011-09-28 Thread Campbell Barton
Having no compiler warnings is a nice target, some years back developers would add in implicit declarations which would go unnoticed causing crashes in some cases, but now these are set as errors (on GCC at least). Newer GCC versions warn of values being "Set but not used", while having no compile

Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [40677] trunk/blender/source/blender/ editors/animation/anim_filter.c: Reverting part of r.40659

2011-09-28 Thread Bastien Montagne
I’m sorry about this… I thought having the “clear” process in commented form was enough. Will be even more cautious in my future commits when trying to silent gcc warnings. Regards, Bastien On Thu, Sep 29, 2011 at 05:41:03 AM CEST, Campbell Barton wrote: > Having no compiler warnings is a nice