Hi,
Pardon for late reply on this thing but unfortunately didn't check code
that time.
This is still not a check for orthogonal matrix, it's check for orthonormal
matrix which is slight different things and current behavior/naming is
confusing.
I'd say either we need to rename function to make
Sorry for double posting, I'm not sure if the previous mail got to the list.
Old behavior:
Matrix(((0, 0, 10), (0, 20, 0), (0, 0, 0))).is_orthogonal returned
true, but this matrix is not orthogonal
Matrix(((0, 0, 1, 42), (0, 1, 0, 0x42), (0, 0, 0, 100500), (-42, 42,
0xDEAD,
Can you give an example as to what case this fixes?
On Fri, Jan 27, 2012 at 4:11 AM, Sv. Lockal lockals...@gmail.com wrote:
Revision: 43733
http://projects.blender.org/scm/viewvc.php?view=revroot=bf-blenderrevision=43733
Author: lockal
Date: 2012-01-26 17:11:43 + (Thu, 26
Hi Campbell,
This fix adds the condition that the columns be unit length which is a
requirement of orthogonal matrices [1].
From Python you can check this with the code here [2]. This matrix is not
orthogonal, even though its columns are. For another example of a matrix
which has orthogonal
Looking at the original code, it does not appear to be the intention to
check for true matrix orthogonality, but only to check the upper 3x3
matrix. Although it still does not check the normality condition of
columns. Whether this is the intention, or an error I'm not sure. Would be
useful to see