Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [51027] trunk/blender/source/blender/imbuf /intern/colormanagement.c: colormanage_colorspace_get_named() can (and does ) return NU

2012-10-03 Thread Thomas Dinges
Reminder, we are still in SVN freeze! (Bcon5) No need to revert this, but please no more commits until further notice. Thanks. Am 03.10.2012 23:52, schrieb Dan Eicher: > Revision: 51027 > > http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=51027 > Author:

Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [51027] trunk/blender/source/blender/imbuf /intern/colormanagement.c: colormanage_colorspace_get_named() can (and does ) return NU

2012-10-03 Thread Dan Eicher
On Wed, Oct 3, 2012 at 3:04 PM, Thomas Dinges wrote: > Reminder, we are still in SVN freeze! (Bcon5) > > No need to revert this, but please no more commits until further notice. > Thanks. > This one's a crasher. Also the CPack rpm builder (and probably the .deb builder too) needs to install data

Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [51027] trunk/blender/source/blender/imbuf /intern/colormanagement.c: colormanage_colorspace_get_named() can (and does ) return NU

2012-10-03 Thread Sergey Sharybin
Function you mentioned should not return null and if if does -- some datablock's color space is configured wrong and that's what should be fixed. This probably prevents crash but currently i don't consider it's a correct fix and would want to have feedback about circumstances when crash happens he

Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [51027] trunk/blender/source/blender/imbuf /intern/colormanagement.c: colormanage_colorspace_get_named() can (and does ) return NU

2012-10-03 Thread Dan Eicher
On Wed, Oct 3, 2012 at 11:21 PM, Sergey Sharybin wrote: > Function you mentioned should not return null and if if does -- some > datablock's color space is configured wrong and that's what should be fixed. > > This probably prevents crash but currently i don't consider it's a correct > fix and wou

Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [51027] trunk/blender/source/blender/imbuf /intern/colormanagement.c: colormanage_colorspace_get_named() can (and does ) return NU

2012-10-04 Thread Sergey Sharybin
This isn't usual scenario behavior (you *should* have OCIO configuration). Correct fix would be to fallback to "stub"-based OCIO API which would be much more predictable and which isn't so much difficult to implement. I know about this issue and i'll work on this after codebase unfreeze. The issue