[Bf-committers] [PATCH] Patch to storage.c to avoid crash on long userids

2010-03-28 Thread Jochen Schmitt
Hallo, on https://bugzilla.redhat.com/show_bug.cgi?id=572186 an user complains a crash which seems to occured, if he use an userid which contains more the 15 characters. I have found a line in the file storage.c where an userid which will be returned by the getpwent() function. This userid will

Re: [Bf-committers] [PATCH] Patch to storage.c to avoid crash on long userids

2010-03-29 Thread Rob M
r.org > Subject: [Bf-committers] [PATCH] Patch to storage.c to avoid crash on > long userids > > Hallo, > > on > > https://bugzilla.redhat.com/show_bug.cgi?id=572186 > > an user complains a crash which seems to occured, if he use > an userid which contains more

Re: [Bf-committers] [PATCH] Patch to storage.c to avoid crash on long userids

2010-03-29 Thread Jochen Schmitt
Am 29.03.2010 11:43, schrieb Rob M: > Hi, > > The patch is bad style. You should not pass literal sizes to strncpy - what > happens when someone changes the size of the array? > Passing sizeof(files[num].owner) is better (but doesn't allow easy > translation from 8bit chars to wide chars). > Would

Re: [Bf-committers] [PATCH] Patch to storage.c to avoid crash on long userids

2010-03-29 Thread Campbell Barton
applied a fix for this in the render branch, will merge to trunk in a day or 2. http://markmail.org/message/awnbh2zzdivks657 On Mon, Mar 29, 2010 at 4:11 PM, Jochen Schmitt wrote: > Am 29.03.2010 11:43, schrieb Rob M: >> Hi, >> >> The patch is bad style. You should not pass literal sizes to strnc