[Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-01 Thread Tobias Oelgarte
Im currently reviewing the armature code to fix the loss of precession while switching between edit mode and pose mode. Basically the locations and roll angles are computed back and forth every time. Since it is done with floating point precession the rig tends to fall apart. To correct that i

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-01 Thread Tom Edwards
Why are heads and tails stored anyway? This would be a great opportunity to make editbones loc, rot, length. The difference between edit and pose is bizarre from both a user's and developer's perspective, and a huge HUGE headache when importing/exporting. On 01/02/2011 2:13, Tobias Oelgarte wro

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-01 Thread Tobias Oelgarte
I don't know. Maybe it is easier to write code for the positioning of the bones in edit-mode and it wastes less space while storing. The real issue behind this is the steady conversion between this two types of structs. Everytime it will compute the boneroll, head and tail again as you enter ed

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-01 Thread Tobias Oelgarte
OK. Now i wrote a patch against it. It's a little bit a hack, since i need to ensure that the roll is at least computed once while importing older files. New Files will store the roll after applying this patch. What it does: * It prevents any modification onto the bones while switching between

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-01 Thread Stephen Swaney
On Tue, Feb 01, 2011 at 06:04:59PM +0100, Tobias Oelgarte wrote: > > The patch: > * http://pastebin.com/mV5BwHqW Blender has a Patch Tracker. Putting patches in our tracker makes it easier to review and maintain them. Making it easier for patch reviewers is making it easier to get your patch

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-01 Thread Brecht Van Lommel
Hi, This patch and the other one you posted contain many formatting changes, please keep those out of patches, it's hard to see what you changed. Regarding this fix, it would be better to store original roll/head/tail + loc/rot/scale on entering edit mode in the EditBone, and then use that when y

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-01 Thread Tobias Oelgarte
@ Brecht Van Lommel: You are right. I should have not made any further changes. But regarding the storage of the variables i can't imagine a better place, since the editmode is where the precession comes from. If you store the restpositions in editmode and check with some delta against it, you

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-01 Thread Tobias Oelgarte
I fixed the issues with the patch and uploaded it to the tracker: http://projects.blender.org/tracker/index.php?func=detail&aid=25901&group_id=9&atid=127 The only thing that is missing is a check for older files. (See the description on the tracker for further information) I still need to find o

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-01 Thread Brecht Van Lommel
Hi, We should continue discussion in the patch tracker, please open a report there. I'll reply later trying to explain what I mean, I still think this is the wrong solution... Brecht. On Tue, Feb 1, 2011 at 7:12 PM, Tobias Oelgarte wrote: > But regarding the storage of the variables i can't ima

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-01 Thread Tobias Oelgarte
What do you mean with "please open a report"? I already added a patch proposal at: https://projects.blender.org/tracker/index.php?func=detail&aid=25901&group_id=9&atid=127 Did you mean something else, a bugreport maybe? (Im not familiar with the tracker) Am 01.02.2011 21:11, schrieb Brecht Van

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-01 Thread Brecht Van Lommel
It's fine, I received your last e-mail after I sent mine. Brecht. On Tue, Feb 1, 2011 at 9:19 PM, Tobias Oelgarte wrote: > What do you mean with "please open a report"? I already added a patch > proposal at: > https://projects.blender.org/tracker/index.php?func=detail&aid=25901&group_id=9&atid=1

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-02 Thread Tobias Oelgarte
I tried to submit a new patch. But i forgot to add it to the attachments. Now i have the problem that i can't make an additional post (with attachment, blames me for double posting), neither i can upload only the attachment (blames me for missing parameter). What now? Am 01.02.2011 22:13, schri

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-02 Thread Nathan Letwory
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2.2.2011 12:58, Tobias Oelgarte wrote: > I tried to submit a new patch. But i forgot to add it to the > attachments. Now i have the problem that i can't make an additional post > (with attachment, blames me for double posting), neither i can uploa

Re: [Bf-committers] Question about bone allocation (Chicken or the egg)

2011-02-02 Thread Tobias Oelgarte
Thank you. Now it's up. Am 02.02.2011 12:24, schrieb Nathan Letwory: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 2.2.2011 12:58, Tobias Oelgarte wrote: >> I tried to submit a new patch. But i forgot to add it to the >> attachments. Now i have the problem that i can't make an additiona