[Bf-committers] REVIEW: Predivide for premultiplied images patch. ATTN: Brecht

2011-09-28 Thread Troy Sobotka
In the ever ongoing deluxe saga of trying to get Blender to correctly ingest premultiplied alpha images such as TIFFs, the following patch is offered for review. Special thanks go to Brecht for his extreme patience and sagely advice. ATTN: This patch also adds in the three lines of code to properl

Re: [Bf-committers] REVIEW: Predivide for premultiplied images patch. ATTN: Brecht

2011-09-30 Thread Brecht Van Lommel
Hi, A quick review: * The BLI_CM_ should not be in blenlib, there should be separate flags in DNA_image_types.h and IMB_imbuf_types.h. This adds a bit more code, but these things should be decoupled. * I'd also be inclined to not add a separate cm_flags but use the existing flag members in ImBuf

Re: [Bf-committers] REVIEW: Predivide for premultiplied images patch. ATTN: Brecht

2011-09-30 Thread Troy Sobotka
Thanks for looking Brecht. Some clarifications as discussed via IRC but put here for posterity and searching: On Fri, Sep 30, 2011 at 7:37 AM, Brecht Van Lommel wrote: > * The BLI_CM_ should not be in blenlib, there should be separate flags > in DNA_image_types.h and IMB_imbuf_types.h. This adds