[Bf-committers] Restricting code cleanup

2012-12-29 Thread Sergey Sharybin
Hi, Proposal would be to stop cleaning up code unless this is really needed (and i talk about need as in when code style prevents from understanding the code when working on new feature/fix) or when one does larger changes in the area caused by new feature/fix for a bug (in this case you can not a

Re: [Bf-committers] Restricting code cleanup

2012-12-29 Thread Thomas Dinges
I agree with this Sergey, Code and especially Style cleanups should be avoided during bcon 1/2 so other branches won't have merge issues. +1 Am 29.12.2012 18:02, schrieb Sergey Sharybin: > Hi, > > Proposal would be to stop cleaning up code unless this is really needed > (and i talk about need as

Re: [Bf-committers] Restricting code cleanup

2012-12-29 Thread Ton Roosendaal
Hi, I guess it's time for Campbell to pick a new pet project :) Code readability (style) has indeed improved a lot, but doing this announced in advance on specific moments only would be nice to agree on from now on. -Ton-

Re: [Bf-committers] Restricting code cleanup

2012-12-30 Thread Campbell Barton
On Sun, Dec 30, 2012 at 4:33 AM, Ton Roosendaal wrote: > Hi, > > I guess it's time for Campbell to pick a new pet project :) > Code readability (style) has indeed improved a lot, but doing this announced > in advance on specific moments only would be nice to agree on from now on. > > -Ton- > > --

Re: [Bf-committers] Restricting code cleanup

2012-12-30 Thread Sergey Sharybin
> > * Small-localized cleanups in areas of the code that are being updated. > For example, while updating text editor syntax highlighting I found > some of the code a bit cryptic and did some cleanup commits. > Example of small-localized edits: r53416, r53418 > If it's just cryptic but doesn't aff