Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-07 Thread François T .
Sorry Xavier, I didn't mean it that way. I was more referring to the workflow of having realtime feedback of the scopes in the sequencer compare to the compositor rather than the scope code itself. Like Troy says, it more the underlying design of both compositor and Sequencer where one is meant to

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-07 Thread Xavier Thomas
Hi, sorry if this is considered high-jacking the thread. What do you mean by no scopes in the compositor? You can use a viewer node and use the (fantastic :) scopes of the UV/image editor. What would you prefer? A "scope node" that display the scope directly in it's own UI in the node editor? That

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-07 Thread François T .
I would second Troy on that, if you are going for a node as simple as a vignette, try to make it as accurate as possible which can handle real AC and could do reverse vignette, and part of this is usually linked to the Lens model. Going for a simple node which only do a mask or compute the length o

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread Akash Hamirwasia
Hi again! Look if a Vignette node which I have created can be added by default in Blender, it can be pretty helpful to everyone. Also there are no presets in Node groups of Blender's compositor. If these presets for Blender can be made default, then later it would be easy to add more nodes, making

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread Ton Roosendaal
Hi, The compositor was designed for a frame workflow, for rendering 3d, for combining vfx and footage into a shot. That is being done in linear color, and it's advised to keep its file output as pure as possible (floating point colors with high dynamic range). These shots then get combined to

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread Diego Gangl
Hi guys, We also have to consider: more nodes = more code = more bugs and less optmization. Speeding up (if possible) the blur, mix and ellipse mask nodes would be a better improvement for vignettes IMHO. Cheers, 2015-03-05 11:55 GMT-03:00 Troy Sobotka : > On Mar 5, 2015 6:13 AM, "Johnny Matthew

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread Johnny Matthews
Sure in a basic take a blurry mask and multiply it against an image, there is not really efficiency to be gained, I was thinking on a more generic sense of some node groups may benefit from compiler level optimization. I think your breakdown of a possible vignette node to end all vignette nodes, s

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread Troy Sobotka
On Mar 5, 2015 6:13 AM, "Johnny Matthews" wrote: > > Oh you burned me so bad there. It wasn't intended as a burn, and I regret that you saw it as such. The idea that a multiplication isn't complex was directed at the suggestion that there would be “efficiencies” if coded at a more “atomic” level

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread Johnny Matthews
Oh you burned me so bad there. On Thu, Mar 5, 2015, 7:47 AM Troy Sobotka wrote: > Multiplication isn't exactly complex. > > With respect, > TJS > > On Thu, Mar 5, 2015, 5:25 AM Johnny Matthews > wrote: > > > True, but is it out of the question that some of the node groups could > have > > effic

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread Troy Sobotka
Multiplication isn't exactly complex. With respect, TJS On Thu, Mar 5, 2015, 5:25 AM Johnny Matthews wrote: > True, but is it out of the question that some of the node groups could have > efficiencies added by coding them more atomically? > > On Thu, Mar 5, 2015 at 7:07 AM Kévin Dietrich > wro

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread Johnny Matthews
True, but is it out of the question that some of the node groups could have efficiencies added by coding them more atomically? On Thu, Mar 5, 2015 at 7:07 AM Kévin Dietrich wrote: > > > Le 2015-03-05 14:00, Johnny Matthews a écrit : > > > David, I'm not sure your tone here is helpful. > > > > Al

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread Kévin Dietrich
Le 2015-03-05 14:00, Johnny Matthews a écrit : > David, I'm not sure your tone here is helpful. > > Also to take a stab at "where would the devs stop?" Take a look at > http://www.redgiant.com/products/magic-bullet-looks/ [1] That would be the equivalent to having a node groups library, whic

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread Johnny Matthews
David, I'm not sure your tone here is helpful. Also to take a stab at "where would the devs stop?" Take a look at http://www.redgiant.com/products/magic-bullet-looks/ On Thu, Mar 5, 2015 at 6:14 AM David McSween <3pointe...@gmail.com> wrote: > Really its not that hard to make with 2 or three no

Re: [Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread David McSween
Really its not that hard to make with 2 or three nodes. If that takes to long then save it as a node group to append in later. Otherwise where would the devs stop, making a node for every function you think up? Cheers, David Mcsween On 5 Mar 2015 22:10, "Akash Hamirwasia" wrote: > Hello! > > I h

[Bf-committers] Vignette node for Blender's Compositor

2015-03-05 Thread Akash Hamirwasia
Hello! I have found out that creating vignettes in Blender's compositor can take time and other people agree with it. Also if there is a Vignette node, it will make people be focused on compositing rather than spending their time in creating a Vignette. Also I had created a video on it which you