Re: [Bioc-devel] Questions about some checks in the latest BiocCheck

2018-11-29 Thread Michael Lawrence
On Thu, Nov 29, 2018 at 8:32 AM Kasper Daniel Hansen wrote: > > First, the issue with using class() is that the return is a vector possibly > with >1 element. This _does_ happen. This is why is() etc is much better,. > And of course it also considers S4 inheritance. > Second, why do you need ca

Re: [Bioc-devel] Questions about some checks in the latest BiocCheck

2018-11-29 Thread Kasper Daniel Hansen
First, the issue with using class() is that the return is a vector possibly with >1 element. This _does_ happen. This is why is() etc is much better,. Second, why do you need case insensitivity when testing for class. That makes NO sense to me. You should be testing for a specific (collection) of