Re: [Bioc-devel] [ext] Re: Vignettes for a data processing package

2019-08-05 Thread Vincent Carey
I think we can take this to a one-to-one discussion for now and report back to bioc-devel. I have done a little work with the package and have some comments. On Mon, Aug 5, 2019 at 1:16 PM Dermot Harnett wrote: > Hi Vincent - thanks, much appreciated. > > Here's the current development version

Re: [Bioc-devel] [ext] Re: Vignettes for a data processing package

2019-08-05 Thread Dermot Harnett
Hi Vincent - thanks, much appreciated. Here's the current development version of the repository. https://github.com/ohlerlab/RiboseQC/ On Mon, Aug 5, 2019 at 1:22 PM Vincent Carey wrote: > Is there an open github repository where this can be ex

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-05 Thread Shepherd, Lori
Hi George, No problem at all. We are glad to help and glad you are being so cautious. I am able to see the successful commit/changes on devel (master branch). So that has been successful. You would need to make similar changes to the RELEASE_3_9 branch as your package was failing in both

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-05 Thread George Weingart
Hi Lori, I followed your instructions and went as far as “git push upstream master” Do I need to do the “(Optional) Merge changes to the current release branch” ? As I mentioned, I am being extra careful so I do not damage the repository. Thanks so much for your help !! George Here is the lo

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-05 Thread Shepherd, Lori
So you only have a Bioconductor git repository, not your own github repository to also keep track of changes? Then these instructions are correct: http://bioconductor.org/developers/how-to/git/maintain-bioc-only/ We normal recommend changing the name of the remote from origin to upstream so

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-05 Thread George Weingart
Hi Lori, Here is the display you wanted to see. Tanias-MacBook-Air:banocc georgeweingart$ *git remote -v* origin g...@git.bioconductor.org:packages/banocc (fetch) origin g...@git.bioconductor.org:packages/banocc (push) Tanias-MacBook-Air:banocc georgeweingart$ So what should the next step be

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-05 Thread Shepherd, Lori
Can you please display the results from git remote -v It looks like you may have not setup the remote to point to the Biocondutor repository. # 2 from here: http://bioconductor.org/developers/how-to/git/sync-existing-repositories/ The code below looks like it is pulling and comparing to

Re: [Bioc-devel] Vignettes for a data processing package

2019-08-05 Thread Vincent Carey
Is there an open github repository where this can be examined as a work in progress? If so please let us know and I and likely others will take a look and make recommendations. On Mon, Aug 5, 2019 at 6:55 AM Dermot Harnett wrote: > Hi > I've been put in charge of trying to clean up a package pr

[Bioc-devel] Vignettes for a data processing package

2019-08-05 Thread Dermot Harnett
Hi I've been put in charge of trying to clean up a package produced in my lab into bioconductor compatible code. The package consists of a a few functions (which process annotation, process bam files, and then create a html report, respectively). Each of these functions necessarily take a long tim