Re: [Bioc-devel] Packages with broken unit tests because of sample() change in R 3.6

2019-04-17 Thread Pages, Herve
Hi Leonardo, Thanks for fixing the derfinder and derfinderHelper tests. Note that Luke Tierney already suggested the RNGversion("3.5.0") trick on this list last month. IMO using RNGversion("3.5.0") to repair the unit tests broken by this change in R 3.6 should be considered a temporary

Re: [Bioc-devel] Packages with broken unit tests because of sample() change in R 3.6

2019-04-10 Thread Leonardo Collado Torres
Thanks Hervé, I also found this tweet by John Muschelli useful for this situation https://twitter.com/StrictlyStat/status/1103303028751372289 where he suggests using suppressWarnings(RNGversion("3.5.0")) That's what I did for example in

[Bioc-devel] Packages with broken unit tests because of sample() change in R 3.6

2019-04-08 Thread Pages, Herve
Dear developers, As reported on this list in March (https://stat.ethz.ch/pipermail/bioc-devel/2019-March/014776.html) the sample() function has changed in recent R-devel. This change breaks the 19 following Bioconductor software packages: - cicero - clipper - clusterExperiment - CMA