[Bioc-devel] Fixing bugs in release version

2018-07-12 Thread Eugenia Galeota
Good morning, I'm writing because I tried to fix some bugs in the current release version of my package Onassis. I followed these instructions ( https://bioconductor.org/developers/how-to/git/bug-fix-in-release-and-devel/ ) but maybe I messed up with the version in the DESCRIPTION file. In the Bioc

Re: [Bioc-devel] Fixing bugs in release version

2018-07-12 Thread Mike Smith
It looks to me like you have made the changes correctly. When I checkout your packages you have versions 1.3.1 and 1.2.1 for the master and RELEASE_3_7 branches respectively. -> % git checkout --quiet master && cat DESCRIPTION | grep Version Version: 1.3.1 -> % git checkout --quiet RELEASE_3_7 &

Re: [Bioc-devel] Fixing bugs in release version

2018-07-12 Thread Jason Serviss
Mike, It would appear that the version on Eugenia’s RELEASE_3_7 branch on her git repo is 1.3.1 (https://github.com/eugeniaeueu/Onassis/commit/def6111f80db3ed03a991416ce724425d2027d01) so why is it 1.2.1 on the Bioconductor repo? p.s. have recently been struggling with a similar issue so, jus

Re: [Bioc-devel] Fixing bugs in release version

2018-07-12 Thread Mike Smith
Hi Jason, There is no explicit connection between Github and git.bioconductor.org (I'm going to call this git.bioc from now on) Only changes that are pushed to git.bioc will be reflected in the packages available via www.bioconductor.org and biocLite(). You can make any changes you like to a rep

Re: [Bioc-devel] Fixing bugs in release version

2018-07-12 Thread Jason Serviss
Mike, Thanks for your reply. I understand that there is no “automatic syncing” between Github and git.bioc and that changes made on Github need to be explicitly pushed to git.bioc to be reflected in the packages available via biocLite. Although, it would seem as though, from Eugenia’s original

Re: [Bioc-devel] Fixing bugs in release version

2018-07-12 Thread Eugenia Galeota
Before the bug fixes I was just working on a master and devel branch on my Github connected with bioconductor repository (through upstream). When I decided to fix some of the bugs in the release version I just followed the instructions in the page that I linked in the first message. It's when I als

Re: [Bioc-devel] Fixing bugs in release version

2018-07-12 Thread Jason Serviss
Eugenia, The easiest way to see the logs for git.bioc master branch is to look here: http://bioconductor.org/developers/gitlog/. They have an RSS feed for both the master and release branch as well. Since I don’t use RSS I instead did the following: 1) cloned your repo from git.bioc: git clone