Re: [Bioc-devel] renameModelMatrixColumns mishap + patch for DESeq2

2013-07-15 Thread Steve Lianoglou
Thanks, Mike! On Mon, Jul 15, 2013 at 8:04 AM, Michael Love wrote: > hi Steve, > > I have fixed this bug in version 1.0.18 and 1.1.22, and I added a unit > test for such a design formula in the devel version. > > best, > > Mike > > On Wed, Jul 10, 2013 at 8:52 AM, Michael Love > wrote: >> Hi Ste

Re: [Bioc-devel] renameModelMatrixColumns mishap + patch for DESeq2

2013-07-15 Thread Michael Love
hi Steve, I have fixed this bug in version 1.0.18 and 1.1.22, and I added a unit test for such a design formula in the devel version. best, Mike On Wed, Jul 10, 2013 at 8:52 AM, Michael Love wrote: > Hi Steve, > > Thanks for pointing out this bug in the renaming code. I will fix this as > soon

Re: [Bioc-devel] renameModelMatrixColumns mishap + patch for DESeq2

2013-07-11 Thread Steve Lianoglou
Hey Mike, On Tue, Jul 9, 2013 at 11:52 PM, Michael Love wrote: > Hi Steve, > > Thanks for pointing out this bug in the renaming code. I will fix this as > soon as possible. If you decide to go the `subset(convertNames, ...)` route that I suggested: (1) You might want to put this in the renameMo

Re: [Bioc-devel] renameModelMatrixColumns mishap + patch for DESeq2

2013-07-09 Thread Michael Love
Hi Steve, Thanks for pointing out this bug in the renaming code. I will fix this as soon as possible. Best, Mike On Jul 10, 2013 1:00 AM, "Steve Lianoglou" wrote: > Greetings DESeq2ers, > > I've been playing around with different ways to encode a 2x2 factorial > design I'm working with: 4 cell

Re: [Bioc-devel] renameModelMatrixColumns mishap + patch for DESeq2

2013-07-09 Thread Kasper Daniel Hansen
Actually the limma guide is right and I am wrong. For a moment I forgot the precise meaning of ":" in context of R's formula system. You still need to be careful with this, as the limma guide also states quite clearly. Kasper On Tue, Jul 9, 2013 at 9:01 PM, Steve Lianoglou wrote: > Hi Kasper,

Re: [Bioc-devel] renameModelMatrixColumns mishap + patch for DESeq2

2013-07-09 Thread Steve Lianoglou
Hi Kasper, On Tue, Jul 9, 2013 at 5:51 PM, Kasper Daniel Hansen wrote: > This is side-stepping the question, but I am not aware that it ever makes > sense to include the "A:B" term in a design matrix without also including > the main effects of A and B (here I include obvious extensions such as A

Re: [Bioc-devel] renameModelMatrixColumns mishap + patch for DESeq2

2013-07-09 Thread Kasper Daniel Hansen
This is side-stepping the question, but I am not aware that it ever makes sense to include the "A:B" term in a design matrix without also including the main effects of A and B (here I include obvious extensions such as A + A:B + C where B is a coarser factor than C, so here the main effects of B ar

[Bioc-devel] renameModelMatrixColumns mishap + patch for DESeq2

2013-07-09 Thread Steve Lianoglou
Greetings DESeq2ers, I've been playing around with different ways to encode a 2x2 factorial design I'm working with: 4 cell types, 4 treatments and exploring what's cooking in there. I thought that the nested interaction formula used in the limma user's guide (section 8.5.3) would be an easy way