Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-09 Thread Aaron Lun
Martin Morgan wrote: > On 04/08/2017 12:29 PM, Aaron Lun wrote: >> Martin Morgan wrote: >>> On 04/08/2017 08:16 AM, Aaron Lun wrote: On 07/04/17 20:46, luke-tier...@uiowa.edu wrote: > On Fri, 7 Apr 2017, Hervé Pagès wrote: > >> On 04/07/2017 05:37 AM, luke-tier...@uiowa.edu wrote:

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-09 Thread Martin Morgan
On 04/08/2017 12:29 PM, Aaron Lun wrote: Martin Morgan wrote: On 04/08/2017 08:16 AM, Aaron Lun wrote: On 07/04/17 20:46, luke-tier...@uiowa.edu wrote: On Fri, 7 Apr 2017, Hervé Pagès wrote: On 04/07/2017 05:37 AM, luke-tier...@uiowa.edu wrote: On Fri, 7 Apr 2017, Hervé Pagès wrote: On

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-08 Thread Hervé Pagès
On 04/08/2017 06:50 AM, Martin Morgan wrote: On 04/08/2017 08:16 AM, Aaron Lun wrote: On 07/04/17 20:46, luke-tier...@uiowa.edu wrote: On Fri, 7 Apr 2017, Hervé Pagès wrote: On 04/07/2017 05:37 AM, luke-tier...@uiowa.edu wrote: On Fri, 7 Apr 2017, Hervé Pagès wrote: On 04/06/2017 03:29

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-08 Thread Aaron Lun
Martin Morgan wrote: > On 04/08/2017 08:16 AM, Aaron Lun wrote: >> On 07/04/17 20:46, luke-tier...@uiowa.edu wrote: >>> On Fri, 7 Apr 2017, Hervé Pagès wrote: >>> On 04/07/2017 05:37 AM, luke-tier...@uiowa.edu wrote: > On Fri, 7 Apr 2017, Hervé Pagès wrote: > >> On 04/06/2017 03:

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-08 Thread Martin Morgan
On 04/08/2017 08:16 AM, Aaron Lun wrote: On 07/04/17 20:46, luke-tier...@uiowa.edu wrote: On Fri, 7 Apr 2017, Hervé Pagès wrote: On 04/07/2017 05:37 AM, luke-tier...@uiowa.edu wrote: On Fri, 7 Apr 2017, Hervé Pagès wrote: On 04/06/2017 03:29 AM, Michael Lawrence wrote: On Thu, Apr 6, 20

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-08 Thread Aaron Lun
On 07/04/17 20:46, luke-tier...@uiowa.edu wrote: > On Fri, 7 Apr 2017, Hervé Pagès wrote: > >> On 04/07/2017 05:37 AM, luke-tier...@uiowa.edu wrote: >>> On Fri, 7 Apr 2017, Hervé Pagès wrote: >>> >>> > On 04/06/2017 03:29 AM, Michael Lawrence wrote: >>> > > On Thu, Apr 6, 2017 at 2:59 AM, Martin

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-07 Thread Gabe Becker
On Fri, Apr 7, 2017 at 12:46 PM, wrote: > On Fri, 7 Apr 2017, Hervé Pagès wrote: > > On 04/07/2017 05:37 AM, luke-tier...@uiowa.edu wrote: >> >>> On Fri, 7 Apr 2017, Hervé Pagès wrote: >>> >>> > On 04/06/2017 03:29 AM, Michael Lawrence wrote: >>> > > On Thu, Apr 6, 2017 at 2:59 AM, Martin Morg

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-07 Thread luke-tierney
On Fri, 7 Apr 2017, Hervé Pagès wrote: On 04/07/2017 05:37 AM, luke-tier...@uiowa.edu wrote: On Fri, 7 Apr 2017, Hervé Pagès wrote: > On 04/06/2017 03:29 AM, Michael Lawrence wrote: > > On Thu, Apr 6, 2017 at 2:59 AM, Martin Morgan > > wrote: > > > On 04/06/2017 05:33 AM, Aaron Lun wrote

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-07 Thread Hervé Pagès
On 04/07/2017 05:37 AM, luke-tier...@uiowa.edu wrote: On Fri, 7 Apr 2017, Hervé Pagès wrote: On 04/06/2017 03:29 AM, Michael Lawrence wrote: On Thu, Apr 6, 2017 at 2:59 AM, Martin Morgan wrote: On 04/06/2017 05:33 AM, Aaron Lun wrote: The tool is not perfect, so assess each report carefull

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-07 Thread luke-tierney
On Fri, 7 Apr 2017, Hervé Pagès wrote: On 04/06/2017 03:29 AM, Michael Lawrence wrote: On Thu, Apr 6, 2017 at 2:59 AM, Martin Morgan wrote: On 04/06/2017 05:33 AM, Aaron Lun wrote: The tool is not perfect, so assess each report carefully. I get a lot of warnings because the tool seems to

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-07 Thread Hervé Pagès
On 04/06/2017 03:29 AM, Michael Lawrence wrote: On Thu, Apr 6, 2017 at 2:59 AM, Martin Morgan wrote: On 04/06/2017 05:33 AM, Aaron Lun wrote: The tool is not perfect, so assess each report carefully. I get a lot of warnings because the tool seems to consider that extracting an attribute (wi

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-06 Thread Michael Lawrence
On Thu, Apr 6, 2017 at 2:59 AM, Martin Morgan wrote: > On 04/06/2017 05:33 AM, Aaron Lun wrote: >>> >>> The tool is not perfect, so assess each report carefully. >> >> >> I also get a warning on almost every C++ function I've written, because >> I use the following code to handle exceptions: >> >>

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-06 Thread Martin Morgan
On 04/06/2017 05:33 AM, Aaron Lun wrote: The tool is not perfect, so assess each report carefully. I also get a warning on almost every C++ function I've written, because I use the following code to handle exceptions: SEXP output=PROTECT(allocVector(...)); try { // do someth

Re: [Bioc-devel] PROTECT errors in Bioconductor packages

2017-04-06 Thread Aaron Lun
> The tool is not perfect, so assess each report carefully. I also get a warning on almost every C++ function I've written, because I use the following code to handle exceptions: SEXP output=PROTECT(allocVector(...)); try { // do something that might raise an exception }