Re: OSPF performance/SPF calculations

2010-04-26 Thread Ondrej Zajicek
On Mon, Apr 26, 2010 at 01:04:44AM +0200, Joakim Tjernlund wrote: BIRD does not use link availability information, therefore if you pull the cable, BIRD keeps the whole subnet in the router-LSA (if it is a stub network). If you do(any plans?), my vote is to leave a host stub in the R-LSA

RE: OSPF performance/SPF calculations

2010-04-26 Thread Andrew Lemin
...@atrey.karlin.mff.cuni.cz] On Behalf Of Joakim Tjernlund Sent: 26 April 2010 00:05 To: Ondrej Zajicek Cc: bird-us...@trubka.network.cz Subject: Re: OSPF performance/SPF calculations Ondrej Zajicek santi...@crfreenet.org wrote on 2010/04/25 23:20:33: On Sun, Apr 25, 2010 at 06:08:04PM +0200, Joakim Tjernlund wrote

RE: OSPF performance/SPF calculations

2010-04-26 Thread Joakim Tjernlund
Andrew Lemin andrew.le...@monitorsoft.com wrote on 2010/04/26 10:46:36: Hello. There are users out there who do desperately want multipath routing support in Bird. Please don't just ignore the need for multipath. The SPF work to support that should not be very hard I think, but I have no

RE: OSPF performance/SPF calculations

2010-04-26 Thread Andrew Lemin
: RE: OSPF performance/SPF calculations Andrew Lemin andrew.le...@monitorsoft.com wrote on 2010/04/26 10:46:36: Hello. There are users out there who do desperately want multipath routing support in Bird. Please don't just ignore the need for multipath. The SPF work to support that should

RE: OSPF performance/SPF calculations

2010-04-26 Thread Joakim Tjernlund
Andrew Lemin andrew.le...@monitorsoft.com wrote on 2010/04/26 12:14:52: Hello. Yes, I believe the changes should not be that difficult. For example, by simply creating two separate 'RIP protocol' instances which listen on different external interfaces, I can get bird's internal core routing

RE: OSPF performance/SPF calculations

2010-04-26 Thread Andrew Lemin
it is not there, it is not a problem however. I am not a developer. Thanks again. Andy. -Original Message- From: Joakim Tjernlund [mailto:joakim.tjernl...@transmode.se] Sent: 26 April 2010 13:32 To: Andrew Lemin Cc: bird-us...@trubka.network.cz; Ondrej Zajicek Subject: RE: OSPF performance/SPF

Re: OSPF performance/SPF calculations

2010-04-25 Thread Joakim Tjernlund
Slowly getting back to SPF again .. Ondrej Zajicek santi...@crfreenet.org wrote on 2010/04/23 16:01:16: On Fri, Apr 23, 2010 at 03:27:10PM +0200, Joakim Tjernlund wrote: Anyhow I looked at the new code and it is an improvement but I think there is a flaw: It looks like the ptp code just

Re: OSPF performance/SPF calculations

2010-04-25 Thread Ondrej Zajicek
On Sun, Apr 25, 2010 at 06:08:04PM +0200, Joakim Tjernlund wrote: This is not a problem because both SPF and calc_next_hop() chooses the cheapest (full) ptp link. They both uses the same (local) metrics. Our ptp links typically have the same cost between the same two routers so it is not

Re: OSPF performance/SPF calculations

2010-04-25 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/04/25 23:20:33: On Sun, Apr 25, 2010 at 06:08:04PM +0200, Joakim Tjernlund wrote: This is not a problem because both SPF and calc_next_hop() chooses the cheapest (full) ptp link. They both uses the same (local) metrics. Our ptp links

Re: OSPF performance/SPF calculations

2010-04-23 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/04/21 20:15:07: On Wed, Apr 21, 2010 at 09:41:47AM +0200, Joakim Tjernlund wrote: I am using Quagga ATM but I had a quick look at BIRD and I got a few observations. Hello. Thank you for your tips and notes. The LSA/checksum

Re: OSPF performance/SPF calculations

2010-04-23 Thread Joakim Tjernlund
Joakim Tjernlund/Transmode wrote on 2010/04/21 22:04:06: Ondrej Zajicek santi...@crfreenet.org wrote on 2010/04/21 20:15:07: On Wed, Apr 21, 2010 at 09:41:47AM +0200, Joakim Tjernlund wrote: I am using Quagga ATM but I had a quick look at BIRD and I got a few observations. Hello.

Re: OSPF performance/SPF calculations

2010-04-23 Thread Ondrej Zajicek
On Fri, Apr 23, 2010 at 08:27:40AM +0200, Joakim Tjernlund wrote: Yes, but not at the moment. The endian problem should be addressed when you build the lsa. Does this help at all? In any case, the (int) cast should be there. Removing of endianity swap is correct only if the Fletcher

Re: OSPF performance/SPF calculations

2010-04-23 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/04/23 11:52:26: From: Ondrej Zajicek santi...@crfreenet.org To: Joakim Tjernlund joakim.tjernl...@transmode.se Cc: bird-us...@trubka.network.cz Date: 2010/04/23 11:46 Subject: Re: OSPF performance/SPF calculations On Fri, Apr 23, 2010

Re: OSPF performance/SPF calculations

2010-04-23 Thread Ondrej Zajicek
On Fri, Apr 23, 2010 at 01:06:20PM +0200, Joakim Tjernlund wrote: I must be missing something then(not surprising as I just started looking at BIRD). Why do you need the separate allocation for the body of the LSA then? Why not just adding entries to the allocated LSA header? Ahh, I am

Re: OSPF performance/SPF calculations

2010-04-23 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/04/23 14:22:18: On Fri, Apr 23, 2010 at 01:06:20PM +0200, Joakim Tjernlund wrote: I must be missing something then(not surprising as I just started looking at BIRD). Why do you need the separate allocation for the body of the LSA

Re: OSPF performance/SPF calculations

2010-04-23 Thread Martin Mares
Hello! But it slows down the fletcher checksum as one need to test and extra calculations because of this. Any gain by the separation is lost many times over in the fletcher checksum which could be as simple as(from Quagga with my tweaks): Again, do you have any real numbers backing this

Re: OSPF performance/SPF calculations

2010-04-23 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/04/23 16:09:00: On Fri, Apr 23, 2010 at 10:54:33AM +0200, Joakim Tjernlund wrote: Removing of endianity swap is correct only if the Fletcher checksum would return the same value regardless of endianity swap. Is this a property of the

Re: OSPF performance/SPF calculations

2010-04-23 Thread Ondrej Zajicek
On Fri, Apr 23, 2010 at 04:12:27PM +0200, Joakim Tjernlund wrote: As i looked on the Fletcher checksum, it seems that you cannot just swap the result instead of swapping the checked data. Then there is a bug else where. Fletcher as such does not depend on host endian. It operates on bytes

Re: OSPF performance/SPF calculations

2010-04-23 Thread Joakim Tjernlund
On Fri, Apr 23, 2010 at 04:12:27PM +0200, Joakim Tjernlund wrote: As i looked on the Fletcher checksum, it seems that you cannot just swap the result instead of swapping the checked data. Then there is a bug else where. Fletcher as such does not depend on host endian. It operates on

Re: OSPF performance/SPF calculations

2010-04-23 Thread Ondrej Zajicek
On Fri, Apr 23, 2010 at 05:29:09PM +0200, Joakim Tjernlund wrote: But you also need LSAs in host endianity when doing SPF calculation. Although it would be probably possible to change SPF calculation to use directly BE values it would be huge work and it is questionable whether it wouldn't

Re: OSPF performance/SPF calculations

2010-04-23 Thread Ondrej Filip
On 23.4.2010 14:22, Ondrej Zajicek wrote: On Fri, Apr 23, 2010 at 01:06:20PM +0200, Joakim Tjernlund wrote: I must be missing something then(not surprising as I just started looking at BIRD). Why do you need the separate allocation for the body of the LSA then? Why not just adding entries to

Re: OSPF performance/SPF calculations

2010-04-23 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/04/23 18:46:19: On Fri, Apr 23, 2010 at 05:29:09PM +0200, Joakim Tjernlund wrote: But you also need LSAs in host endianity when doing SPF calculation. Although it would be probably possible to change SPF calculation to use directly BE

OSPF performance/SPF calculations

2010-04-21 Thread Joakim Tjernlund
I am using Quagga ATM but I had a quick look at BIRD and I got a few observations. The LSA/checksum code seem very inefficient. LSAs are built allocating/reallocing bits of memory. This is slow and will case memory fragmentation. The fletcher checksum is very slow as it has extra tests in the

Re: OSPF performance/SPF calculations

2010-04-21 Thread Ondrej Zajicek
On Wed, Apr 21, 2010 at 09:41:47AM +0200, Joakim Tjernlund wrote: I am using Quagga ATM but I had a quick look at BIRD and I got a few observations. Hello. Thank you for your tips and notes. The LSA/checksum code seem very inefficient. LSAs are built allocating/reallocing bits of memory.