Re: Fwd: bird (2.0.4) does not install multipath route in kernel

2019-06-11 Thread Arno O
OK, thank you very much BR Ar Am Di., 11. Juni 2019 um 17:44 Uhr schrieb Ondrej Zajicek < santi...@crfreenet.org>: > On Tue, Jun 11, 2019 at 05:27:59PM +0200, Arno O wrote: > > One more (last) question: > > since when (which Bird) -release is ECMP like this supported? > > Not sure, but basic

Re: Code style?

2019-06-11 Thread Maria Jan Matejka
On 6/11/19 3:49 PM, Ondrej Zajicek wrote: > On Tue, Jun 11, 2019 at 01:37:42PM +, Kenth Eriksson wrote: >> Is there a code style guide to be used when submitting patches to bird? >> An emacs file, clang-format or similar would be useful. > > Hi > > Well, historically different parts of BIRD

[PATCH] First cut on project emacs settings

2019-06-11 Thread Kenth Eriksson
Signed-off-by: Kenth Eriksson --- .dir-locals.el | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 .dir-locals.el diff --git a/.dir-locals.el b/.dir-locals.el new file mode 100644 index ..98b38690 --- /dev/null +++ b/.dir-locals.el @@ -0,0 +1,6 @@ +; Bird project coding

Re: Code style?

2019-06-11 Thread Ondrej Zajicek
On Tue, Jun 11, 2019 at 01:37:42PM +, Kenth Eriksson wrote: > Is there a code style guide to be used when submitting patches to bird? > An emacs file, clang-format or similar would be useful. Hi Well, historically different parts of BIRD used different coding styles, now we try to converge

Re: [PATCH] Add CLI command to test reconfiguration status

2019-06-11 Thread Ondrej Zajicek
On Tue, Jun 11, 2019 at 02:58:33PM +0200, Kenth Eriksson wrote: > This adds the CLI command 'configure status' so that it is possible to > check if reconfiguration is done. Hi We could add this feature, but it should also report more cases (the submitted patch covers just first two): -

Code style?

2019-06-11 Thread Kenth Eriksson
Is there a code style guide to be used when submitting patches to bird? An emacs file, clang-format or similar would be useful. Thanks, Kenth

[PATCH] Add CLI command to test reconfiguration status

2019-06-11 Thread Kenth Eriksson
This adds the CLI command 'configure status' so that it is possible to check if reconfiguration is done. Signed-off-by: Kenth Eriksson --- conf/conf.c | 6 ++ conf/conf.h | 1 + sysdep/unix/config.Y | 3 +++ sysdep/unix/main.c | 7 +++ sysdep/unix/unix.h | 1 + 5

Re: How to determine when reconfiguration is complete?

2019-06-11 Thread Kenth Eriksson
On Wed, 2019-06-05 at 07:22 +0200, Patrick Schaaf wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you recognize the sender > and know the content is safe. > > > On Tue, Jun 4, 2019 at 9:08 PM Cybertinus wrote: > > What I

Re: bird (2.0.4) does not install multipath route in kernel

2019-06-11 Thread Kenth Eriksson
On Tue, 2019-06-11 at 14:18 +0200, Arno O wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you recognize the sender > and know the content is safe. > > This topic was already discussed around March 1st 2019, without >

Fwd: bird (2.0.4) does not install multipath route in kernel

2019-06-11 Thread Arno O
Sorry, there of course are "protocol kernel" configs. as below: # routing tables with the OS kernel. One instance per table. protocol kernel { ipv4 { # Connect protocol to IPv4 table by channel # table master4; # Default IPv4 table is master4 import all; # Import to table, default is

Re: Introduce Wireguard support to bird

2019-06-11 Thread Toke Høiland-Jørgensen
Bernd Naumann writes: > On 08.06.19 00:18, Toke Høiland-Jørgensen wrote: > >> - The algorithm is basically O(P*M*N) for inserting N routes on an >> interface with P peers that each have M existing AllowedIPs. That is >> not going to scale very far :/ >> >> -Toke > > Hi Toke, > > Could you

Re: radv/OpenWRT: "propagate routes yes" syntax error

2019-06-11 Thread Ondrej Zajicek
On Tue, Jun 11, 2019 at 07:33:45AM +0200, Marvin Gaube wrote: > Hello, > > I'm currently trying to run bird6 on a Gluon-Device (Gluon is build upon > OpenWRT) to announce Router Advertisments. I need to announce more > specific routes, > ... > Every time I'm trying to start bird with "propagate

[PATCH 1/3] Fix bird will close a socket if it reads zero bytes (e.g. due to buffer is full)

2019-06-11 Thread Kenth Eriksson
Datagram sockets may return 0 and stream sockets can return 0 if the requested number of bytes to read is 0. This may happen if the socket buffer is full. Bird event loop will asynchronously process the socket buffer and restore the socket rpos pointer. Thus reading data from the socket will

[PATCH 2/3] Fix issue where cli socket buffer may get full

2019-06-11 Thread Kenth Eriksson
The cli module must reset the socket io buffer rpos when all characters in the socket buffer has been processed. The method cli_get_command is always invoked twice for every CLI command, thus rxpos may also be reset at the second invocation if no newline was found and no new data is input to the

[PATCH 3/3] Fix cli socket close due to io buffer full

2019-06-11 Thread Kenth Eriksson
The pointer rpos in the socket io module is only restored if the rx_hook callback returns 1. Previously the cli_rx hook always returned 0. Guarantee by design that we return 1 if we are at the end of the socket buffer. Signed-off-by: Kenth Eriksson --- sysdep/unix/main.c | 2 +- 1 file changed,