Re: [PATCH] Filter: picking community elements and finding min/max element

2021-12-16 Thread Alexander Zubkov
I suspected, that the syntax may raise questions, but some syntax should have been chosen to make a working patch. :) It does not matter much to me, of course it could be changed in the way you prefer to see it your product. Yes, communities are not arrays, but on the other hand positional addressi

Re: [PATCH] Filter: picking community elements and finding min/max element

2021-12-16 Thread Ondrej Zajicek
On Thu, Dec 16, 2021 at 02:41:28PM +0100, Alexander Zubkov wrote: > Hi everyone! > > I made a couple of patches to do some interesting stuff with communities. > The first patch allows to pick a component from a standard or a large > community: > > (10, 20, 30) @ 2 --> 20 > > And the second patc

Re: Invalid NEXT_HOP attribute for OSPF known route

2021-12-16 Thread Ondrej Zajicek
On Thu, Dec 16, 2021 at 04:41:09PM +0100, Nico Schottelius wrote: > > > Ondrej Zajicek writes: > >> > I expect it is in multihop / > >> > gateway-recursive mode, as it is default for IBGP? > >> > >> It's in direct mode for all links, as the APU-ROUTERS have physical links > >> inside the kuberne

Re: Invalid NEXT_HOP attribute for OSPF known route

2021-12-16 Thread Ondrej Zajicek
On Thu, Dec 16, 2021 at 02:37:00PM +0100, Nico Schottelius wrote: > > Ondrej Zajicek writes: > > Yes, this is kind of confusing error message (as i noted in response > > to Simon Ruderich). > > If there is one thing I'd suggest to improve first: print out the > specific route and the next_hop -

Re: [PATCH] Filter: picking community elements and finding min/max element

2021-12-16 Thread Alexander Zubkov
Of course I forgot to attach the patches. :) On Thu, Dec 16, 2021 at 2:41 PM Alexander Zubkov wrote: > > Hi everyone! > > I made a couple of patches to do some interesting stuff with communities. > The first patch allows to pick a component from a standard or a large > community: > > (10, 20, 30

[PATCH] Filter: picking community elements and finding min/max element

2021-12-16 Thread Alexander Zubkov
Hi everyone! I made a couple of patches to do some interesting stuff with communities. The first patch allows to pick a component from a standard or a large community: (10, 20, 30) @ 2 --> 20 And the second patch allows to search for minimum or maximum element in a community list. This combined