Re: [PATCH] Netlink: Propagate ecmp nexthop weight to kernel for inet6 routes

2022-05-22 Thread Ondrej Zajicek
On Sun, May 22, 2022 at 10:28:12PM +0200, d...@darkboxed.org wrote: > After looking at this more I realise now how bird is splitting multiple > ipv6 nexthops into sequences of route updates for the same prefix. > > Consequently the code doing this should also be removed. Though it seems it > works

Re: [PATCH] Netlink: Propagate ecmp nexthop weight to kernel for inet6 routes

2022-05-22 Thread dxld
After looking at this more I realise now how bird is splitting multiple ipv6 nexthops into sequences of route updates for the same prefix. Consequently the code doing this should also be removed. Though it seems it works just fine either way but I get errors for the (now redundant) route removals.

[PATCH] Netlink: Propagate ecmp nexthop weight to kernel for inet6 routes

2022-05-22 Thread Daniel Gröber
Previously nl_send_route would use plain nl_add_nexthop for ecmp ipv6 routes instead of adding RTA_MULTIPATH objects via nl_add_multipath. The former lacks support for the rtnh_hops field needed for setting the nexthop weight though. On the kernel side support for nexthop weights was introduced by

[PATCH] Netlink: Propagate ecmp nexthop weight to kernel for inet6 routes

2022-05-22 Thread Daniel Gröber
Previously nl_send_route would use plain nl_add_nexthop for ecmp ipv6 routes instead of adding RTA_MULTIPATH objects via nl_add_multipath. The former lacks support for the rtnexthop.rtnh_hops field need for setting the nexthop weight though. On the kernel side support for nexthop weights was intro