Re: [PATCH] bgp: Implement RFC 9234

2022-07-12 Thread Ondrej Zajicek
On Tue, Jul 12, 2022 at 01:54:15PM +0300, Eugene Bogomazov wrote: > Hello, > > I've reviewed all the changes and am happy with them. Had some misgivings > about renaming 'strict mode ' to 'required roles' , but since this option > can be easily found by searching for a phrase in the documentation,

Re: [PATCH] bgp: Implement RFC 9234

2022-07-12 Thread Eugene Bogomazov
Hello, I've reviewed all the changes and am happy with them. Had some misgivings about renaming 'strict mode ' to 'required roles' , but since this option can be easily found by searching for a phrase in the documentation, it looks fine too. Therefore, I have no additional concerns and agree with

Re: [PATCH] bgp: Implement RFC 9234

2022-07-11 Thread Ondrej Zajicek
On Tue, Jun 28, 2022 at 12:37:08PM +0300, Eugene Bogomazov wrote: > Hello everyone, > > The current changes were sufficient to add the described AFI/SAFI check. > Role/OTC rules now only apply to the unicast session. I've checked this on > a stand with a mixture of multicast and unicast sessions a

Re: [PATCH] bgp: Implement RFC 9234

2022-06-28 Thread Eugene Bogomazov
Hello everyone, The current changes were sufficient to add the described AFI/SAFI check. Role/OTC rules now only apply to the unicast session. I've checked this on a stand with a mixture of multicast and unicast sessions and it seems to work well in all cases. As a result, all the necessary basic

Re: [PATCH] bgp: Implement RFC 9234

2022-06-27 Thread Ondrej Zajicek
On Mon, Jun 27, 2022 at 07:07:53PM +0200, Maria Matejka wrote: > Hello! > > On 6/27/22 1:21 PM, Eugene Bogomazov wrote: > > Hi, > > > > I checked BIRD v2.0.10 and didn't find the channel argument in > > bgp_preexport. So AFI/SAFI checks still can't be added there. When will > > it appear? And how

Re: [PATCH] bgp: Implement RFC 9234

2022-06-27 Thread Maria Matejka
Hello! On 6/27/22 1:21 PM, Eugene Bogomazov wrote: Hi, I checked BIRD v2.0.10 and didn't find the channel argument in bgp_preexport. So AFI/SAFI checks still can't be added there. When will it appear? And how can I help the patch get accepted as soon as possible? The "next-preexport" branch

Re: [PATCH] bgp: Implement RFC 9234

2022-06-27 Thread Eugene Bogomazov
Hi, I checked BIRD v2.0.10 and didn't find the channel argument in bgp_preexport. So AFI/SAFI checks still can't be added there. When will it appear? And how can I help the patch get accepted as soon as possible? P.S. A pull request with roles for FRR was accepted today. So, the adoption of our R

Re: [PATCH] bgp: Implement RFC 9234

2022-06-14 Thread Ondrej Zajicek
On Tue, Jun 14, 2022 at 01:35:36PM +0300, Eugene Bogomazov wrote: > TL;DR: What are the best ways to include AFI/SAFI channel check during > attribute creation? Hi > RFC 9234 specifically clarifies that it can only be applied on IPv4/IPv6 > unicast sessions. On all other sessions the OTC attribut

Re: [PATCH] bgp: Implement RFC 9234

2022-06-02 Thread Ondrej Zajicek
On Tue, May 31, 2022 at 02:38:07PM +0300, Eugene Bogomazov wrote: > Hello, > > RFC 9234 provides a new mechanism for route leak detection and prevention. > > In the attachment you can find a patch which introduces this functionality > for BIRD 2.0.9. Hello Thanks for the patch, i will check it

Re: [PATCH] bgp: Implement RFC 9234

2022-05-31 Thread Eugene Bogomazov
Provide a forgotten link for an attachment of RFC 9234 patch 0001-Add-realization-of-Open-Policy-to-bird-version-2.0.9.patch Description: Binary data

[PATCH] bgp: Implement RFC 9234

2022-05-31 Thread Eugene Bogomazov
Hello, RFC 9234 provides a new mechanism for route leak detection and prevention. In the attachment you can find a patch which introduces this functionality for BIRD 2.0.9.