[bitcoin-dev] Initial getheaders request

2015-10-13 Thread Daniel Kraft via bitcoin-dev
Hi! I've stumbled upon the code that does the initial "getheaders" request, i. e., around line 4960 of src/main.cpp [1]. [1] https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L4960 For some reason, it uses not pindexBestHeader but the *preceding* block pindexBestHeader->pprev as the

Re: [bitcoin-dev] The new obfuscation patch & GetStats

2015-10-07 Thread Daniel Kraft via bitcoin-dev
Hi James! On 2015-10-08 02:29, James O'Beirne wrote: > This has been confirmed as a bug. Thanks again for reporting. I've filed > a fix here (https://github.com/bitcoin/bitcoin/pull/6777), and will be > writing tests to prevent regressions. Thanks for the quick fix! I thought to submit a patch m

[bitcoin-dev] The new obfuscation patch & GetStats

2015-10-07 Thread Daniel Kraft via bitcoin-dev
Hi! I hope this is not a stupid question, but I thought I'd ask here first instead of opening a Github ticket (in case I'm wrong). With the recently merged "obfuscation" patch, content of the "chainstate" LevelDB is obfuscated by XOR'ing against a random "key". This is handled by CLevelDBWrapper'