[bitcoin-dev] BIP 174 thoughts

2018-07-10 Thread matejcik via bitcoin-dev
On 6.7.2018 00:06, Pieter Wuille wrote:> The only case where "malicious" conflicting values can occur is when > one of the Signers produces an invalid signature, or modifies any of > the other fields already present in the PSBT for consumption by > others. If this were an issue, it would be an issu

[bitcoin-dev] BIP 174 thoughts

2018-07-06 Thread matejcik via bitcoin-dev
On 4.7.2018 20:35, Achow101 wrote: > You cannot simply reject PSBTs for having conflicting values for the same > key. Especially > for the Partial Signatures, you can have two signatures for the same pubkey > that are both (...) > order to avoid the conflict. That complicates things and is muc

Re: [bitcoin-dev] BIP 174 thoughts

2018-07-05 Thread matejcik via bitcoin-dev
4) > which contains the changes that I proposed in an earlier email. > > Additionally, because there have been no objections to the currently proposed > changes, I propose > to move the BIP from Draft to Proposed status. > > Andrew > > > ​​ >

[bitcoin-dev] BIP 174 thoughts

2018-06-29 Thread matejcik via bitcoin-dev
Short version: - I propose that conflicting "values" for the same "key" are considered invalid. - Let's not optimize for invalid data. - Given that, there's an open question on how to handle invalid data when encountered In general, I don't think it's possible to enforce correctness at the format

Re: [bitcoin-dev] BIP 174 thoughts

2018-06-27 Thread matejcik via bitcoin-dev
hello, On 26.6.2018 18:58, William Casarin wrote: > as a data point, I was able to build a simple serializer[1] in about an > afternoon. I would much prefer to use this lib in say, clightning (my > original goal), without having to have the larger protobuf dependency. To drive my point home, here

Re: [bitcoin-dev] BIP 174 thoughts

2018-06-27 Thread matejcik via bitcoin-dev
hello, On 26.6.2018 22:30, Pieter Wuille wrote: >> (Moreover, as I wrote previously, the Combiner seems like a weirdly >> placed role. I still don't see its significance and why is it important >> to correctly combine PSBTs by agents that don't understand them. If you >> have a usecase in mind, pl

Re: [bitcoin-dev] BIP 174 thoughts

2018-06-26 Thread matejcik via bitcoin-dev
hello, in general, I agree with my colleague Tomas, the proposed changes are good and achieve the most important things that we wanted. We'll review the proposal in more detail later. For now a couple minor things I have run into: - valid test vector 2 ("one P2PKH input and one P2SH-P2WPKH input

Re: [bitcoin-dev] BIP 174 thoughts

2018-06-21 Thread matejcik via bitcoin-dev
On 19.6.2018 19:16, Pieter Wuille wrote: >> 1) Why isn't the global type 0x03 (BIP-32 path) per-input? How do we >> know, which BIP-32 path goes to which input? The only idea that comes to >> my mind is that we should match the input's scriptPubKey's pubkey to >> this 0x03's key (the public key). >

Re: [bitcoin-dev] BIP 174 thoughts

2018-06-19 Thread matejcik via bitcoin-dev
hello, this is our second e-mail with replies to Pieter's suggestions. On 16.6.2018 01:34, pieter.wuille at gmail.com (Pieter Wuille) wrote: > * Key-value map model or set model. > > This was suggested in this thread: > https://twitter.com/matejcik/status/1002618633472892929 > > The motivation b

Re: [bitcoin-dev] BIP 174 thoughts

2018-06-19 Thread matejcik via bitcoin-dev
Hello, First of all, we'd like to apologize for such a late feedback, since there is a PR for this already. We've come up with a few more notes on this, so we are introducing those in this message and replying on Pieter's points in another one. 1) Why isn't the global type 0x03 (BIP-32 path) per