Re: [bitcoin-dev] Code Review: The Consensus Critical Parts of Segwit by Peter Todd

2016-07-04 Thread Peter Todd via bitcoin-dev
On Sun, Jul 03, 2016 at 03:20:42AM +0800, Johnson Lau wrote: > >>> the fact that we do this has a rather odd result: a transaction spending > >>> a witness output with an unknown version is valid even if the transaction > >>> doesn’t have any witnesses! > >> > >> I don’t see any reason to have s

Re: [bitcoin-dev] Code Review: The Consensus Critical Parts of Segwit by Peter Todd

2016-07-02 Thread Johnson Lau via bitcoin-dev
> >>> the fact that we do this has a rather odd result: a transaction spending a >>> witness output with an unknown version is valid even if the transaction >>> doesn’t have any witnesses! >> >> I don’t see any reason to have such check. We simply leave unknown witness >> program as any-one-c

Re: [bitcoin-dev] Code Review: The Consensus Critical Parts of Segwit by Peter Todd

2016-07-02 Thread Peter Todd via bitcoin-dev
On Wed, Jun 29, 2016 at 12:22:45AM +0800, Johnson Lau via bitcoin-dev wrote: > Thanks for Peter Todd’s detailed report: > https://petertodd.org/2016/segwit-consensus-critical-code-review > > I have the following response. > > >Since the reserve value is only a single, 32-byte value, we’re setting

Re: [bitcoin-dev] Code Review: The Consensus Critical Parts of Segwit by Peter Todd

2016-06-28 Thread Johnson Lau via bitcoin-dev
Thanks for Peter Todd’s detailed report: https://petertodd.org/2016/segwit-consensus-critical-code-review I have the following response. >Since the reserve value is only a single, 32-byte value, we’re setting >ourselves up for the same problem again7. Please note that unlimited space has been r