See this BIP. I'm not sure if this is a bug or what, but it would be good if
messages always had a fixed number of fields per protocol version.
https://en.bitcoin.it/wiki/BIP_0060#Code_Updates
This BIP details everything that needs to be done and proposes a protocol
upgrade.
---
It's not a bug (although there was recently a change to make bitcoind/qt
always send this field anyway).
I don't know where Amir is going with BIP 60. Version messages have always
been variable length. There's nothing inherent in the Bitcoin protocol that
says all messages are fixed length, indeed
byte flag needs to be
optional anyway.
From: Mike Hearn
To: Turkey Breast
Cc: Bitcoin Dev
Sent: Tuesday, June 18, 2013 9:48 PM
Subject: Re: [Bitcoin-development] Missing fRelayTxes in version message
It's not a bug (although there was recently a
a 1 byte flag
> needs to be optional anyway.
>
> --
> *From:* Mike Hearn
> *To:* Turkey Breast
> *Cc:* Bitcoin Dev
> *Sent:* Tuesday, June 18, 2013 9:48 PM
> *Subject:* Re: [Bitcoin-development] Missing fRelayTxes in version message
>
key Breast
Cc: "bitcoin-development@lists.sourceforge.net"
Sent: Wednesday, June 19, 2013 11:39 AM
Subject: Re: [Bitcoin-development] Missing fRelayTxes in version message
It has to be optional because old clients don't send it, obviously.
Why is this even an issue? There'
@lists.sourceforge.net" <
> bitcoin-development@lists.sourceforge.net>
> *Sent:* Wednesday, June 19, 2013 11:39 AM
>
> *Subject:* Re: [Bitcoin-development] Missing fRelayTxes in version message
>
> It has to be optional because old clients don't send it, obviously.
------
>> *From:* Mike Hearn
>> *To:* Turkey Breast
>> *Cc:* "bitcoin-development@lists.sourceforge.net" <
>> bitcoin-development@lists.sourceforge.net>
>> *Sent:* Wednesday, June 19, 2013 11:39 AM
>>
>> *Subject:* Re: [Bitcoin-dev
ent@lists.sourceforge.net"
Sent: Wednesday, June 19, 2013 11:39 AM
Subject: Re: [Bitcoin-development] Missing fRelayTxes in version message
It has to be optional because old clients don't send it, obviously.
Why is this even an issue? There's no problem with variable
2013 3:20 PM
Subject: Re: [Bitcoin-development] Missing fRelayTxes in version message
If you want to criticise the Bitcoin protocol for sloppyness, the variable
length of some messages isn't where I'd start.
Note that ping has the same issue, its length has changed over time to inclu
> bitcoin-development@lists.sourceforge.net" <
> bitcoin-development@lists.sourceforge.net>
> *Sent:* Wednesday, June 19, 2013 3:20 PM
>
> *Subject:* Re: [Bitcoin-development] Missing fRelayTxes in version message
>
> If you want to criticise the Bitcoin protocol
eforge.net>
> *Sent:* Wednesday, June 19, 2013 3:20 PM
> *Subject:* Re: [Bitcoin-development] Missing fRelayTxes in version message
>
> If you want to criticise the Bitcoin protocol for sloppyness, the variable
> length of some messages isn't where I'd start.
>
> Note t
On Thu, Jun 20, 2013 at 3:13 AM, Addy Yeow wrote:
> I personally don't treat the relay field as optional, i.e. it is there as
> 0x01 if it is set. Otherwise, it is simply a trailing zero byte. Hence, the
> right way of reading the packet as with any network packet is to first
> retrieve the header
12 matches
Mail list logo
