Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-17 Thread Jeff Garzik
On Fri, Aug 17, 2012 at 9:40 AM, Pieter Wuille wrote: > On Thu, Aug 16, 2012 at 05:05:58PM -0400, Jeff Garzik wrote: >> On MSG_MEMTX: The current version has a much higher Just Works value. >> >> On empty "inv": It is generally better to do something >> unconditionally, than have a response gene

Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-17 Thread Pieter Wuille
On Thu, Aug 16, 2012 at 05:05:58PM -0400, Jeff Garzik wrote: > On MSG_MEMTX: The current version has a much higher Just Works value. > > On empty "inv": It is generally better to do something > unconditionally, than have a response generated only under certain > conditions. > > And Alan is corr

Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-17 Thread Mike Hearn
I think MSG_TX is fine. Simply sending an inv to the other node at startup would work, but it's better to request it explicitly as it will let the connecting peer configure a bloom filter before requesting mempool contents. It's already too heavy for mobile clients to download the entire mempool co

Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-16 Thread Jeff Garzik
On MSG_MEMTX: The current version has a much higher Just Works value. On empty "inv": It is generally better to do something unconditionally, than have a response generated only under certain conditions. And Alan is correct to note that unknown messages are ignored (intentionally, for expansion

Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-16 Thread Amir Taaki
: Thursday, August 16, 2012 8:21 PM Subject: Re: [Bitcoin-development] BIP 35: add mempool message > This seems safe, although it forces other full implementations that want to > expose protocol version 60002 (or later) to also implement this. What do they > think about this? BitcoinJS will impl

Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-16 Thread Alan Reiner
On Thu, Aug 16, 2012 at 2:04 PM, Jeff Garzik wrote: > On Thu, Aug 16, 2012 at 1:56 PM, Pieter Wuille > wrote: > > I suppose it is interesting in general for nodes to > > get a memory pool refill at startup anyway. > > Yes. > > >>An "inv" message is always returned, even if empty. > > > > I'm

Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-16 Thread Stefan Thomas
> This seems safe, although it forces other full implementations that want to > expose protocol version 60002 (or later) to also implement this. What do they > think about this? BitcoinJS will implement it, it's a useful feature and there is no reason not to support it. Two comments from my end:

Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-16 Thread Amir Taaki
August 16, 2012 6:56 PM Subject: Re: [Bitcoin-development] BIP 35: add mempool message On Thu, Aug 16, 2012 at 01:32:04PM -0400, Jeff Garzik wrote: > Consensus was we should do a BIP for all P2P changes, so here it is... >  feedback requested. > > https://en.bitcoin.it/wiki/BIP_0035 I

Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-16 Thread Pieter Wuille
On Thu, Aug 16, 2012 at 01:32:04PM -0400, Jeff Garzik wrote: > Consensus was we should do a BIP for all P2P changes, so here it is... > feedback requested. > > https://en.bitcoin.it/wiki/BIP_0035 I like the idea of being able to query the memory pool of a node; the implementation is straightforw

Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-16 Thread Jeff Garzik
On Thu, Aug 16, 2012 at 1:56 PM, Pieter Wuille wrote: > I suppose it is interesting in general for nodes to > get a memory pool refill at startup anyway. Yes. >>An "inv" message is always returned, even if empty. > > I'm not sure about this last. What is it good for? inv packets can always b

Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-16 Thread Jeff Garzik
On Thu, Aug 16, 2012 at 1:40 PM, Amir Taaki wrote: > The format for "mempool" packet is missing. I'm guessing that it is an empty > message, right? Yes, it is an empty message. BIP updated. -- Jeff Garzik exMULTI, Inc. jgar...@exmulti.com --

Re: [Bitcoin-development] BIP 35: add mempool message

2012-08-16 Thread Amir Taaki
The format for "mempool" packet is missing. I'm guessing that it is an empty message, right? Might be good to add that. - Original Message - From: Jeff Garzik To: Bitcoin Development Cc: Sent: Thursday, August 16, 2012 6:32 PM Subject: [Bitcoin-development] BIP

[Bitcoin-development] BIP 35: add mempool message

2012-08-16 Thread Jeff Garzik
Consensus was we should do a BIP for all P2P changes, so here it is... feedback requested. https://en.bitcoin.it/wiki/BIP_0035 Abstract --- Make a network node's transaction memory pool accessible via a new "mempool" message. Extend the existing "getdata"