Re: [blink-dev] Re: Intent to Ship: Priority Hints

2022-03-04 Thread Mike Taylor
Thanks - agree we don't need to block here, but glad to see it's on your radar as a future improvement. LGTM2. On 3/4/22 5:39 PM, Patrick Meenan wrote: Here's the crbug for the priority property on Request if you'd like to follow along: https://crbug.com/1301942 The only use case that comes

Re: [blink-dev] Re: Intent to Ship: Priority Hints

2022-03-04 Thread Patrick Meenan
Here's the crbug for the priority property on Request if you'd like to follow along: https://crbug.com/1301942 The only use case that comes to mind is for a service worker to behave differently based on the requested priority (though if the same resource is requested multiple times on the page the

Re: [blink-dev] Re: Intent to Ship: Priority Hints

2022-03-04 Thread Patrick Meenan
I'm plumbing the support for the read-only priority property on Request now. It's a fair bit more complicated than I had hoped and requires plumbing through to net and the internal urlrequest but I'm making good progress. I don't think we want to hold shipping on that though. It's a nice-to-have

Re: [blink-dev] Re: Intent to Ship: Priority Hints

2022-03-04 Thread Mike Taylor
This seems genuinely useful, thanks for working on it. What's the current thinking on exposing `priority` on Request, i.e. https://github.com/WICG/priority-hints/issues/11#issuecomment-396610469? On 3/3/22 4:54 PM, Addy Osmani wrote: > Priority Hints introduces a developer-set "fetchpriority"

[blink-dev] Re: Intent to Ship: Priority Hints

2022-03-04 Thread slightlyoff via Chromestatus
LGTM1 Thank you for pushing this over the line. We've needed it for many years, and I'm glad it's finally happening. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email t

Re: [blink-dev] Intent to Ship: Make 'true' a truthy value for window.open boolean features

2022-03-04 Thread Mason Freed
Thank you all for the quick LGTMs. I appreciate the leniency on the "signals" requirements, and I'll definitely watch for issues. I agree that stranger things have happened than expecting =true to result in false. On Fri, Mar 4, 2022 at 7:33 AM Mike Taylor wrote: > LGTM3 - if anything I would ex

Re: [blink-dev] Re: Intent to Experiment: Capture handle

2022-03-04 Thread Yoav Weiss
Indeed! On Fri, Mar 4, 2022 at 4:44 PM Elad Alon wrote: > Thanks! > To clarify, is this inclusive? > > On Fri, Mar 4, 2022 at 4:42 PM Yoav Weiss wrote: > >> LGTM to continue experimenting till M102 >> >> On Fri, Mar 4, 2022 at 3:36 PM 'Elad Alon' via blink-dev < >> blink-dev@chromium.org> wrote

Re: [blink-dev] Re: Intent to Experiment: Capture handle

2022-03-04 Thread 'Elad Alon' via blink-dev
Thanks! To clarify, is this inclusive? On Fri, Mar 4, 2022 at 4:42 PM Yoav Weiss wrote: > LGTM to continue experimenting till M102 > > On Fri, Mar 4, 2022 at 3:36 PM 'Elad Alon' via blink-dev < > blink-dev@chromium.org> wrote: > >> *Intent to extend experiment, I mean. >> >> On Friday, March 4,

Re: [blink-dev] Re: Intent to Experiment: Capture handle

2022-03-04 Thread Yoav Weiss
LGTM to continue experimenting till M102 On Fri, Mar 4, 2022 at 3:36 PM 'Elad Alon' via blink-dev < blink-dev@chromium.org> wrote: > *Intent to extend experiment, I mean. > > On Friday, March 4, 2022 at 3:34:12 PM UTC+1 Elad Alon wrote: > >> Contact emailselad...@chromium.org >> >> Explainerhttps

Re: [blink-dev] Intent to Ship: Make 'true' a truthy value for window.open boolean features

2022-03-04 Thread Mike Taylor
LGTM3 - if anything I would expect things to unbreak (might be interesting to look at histograms for the number of popups opened before and after). On 3/4/22 10:27 AM, Rick Byers wrote: Make true truthy, who could object to that? :-) LGTM2 Seriously though, I agree on the sentiment of the low

Re: [blink-dev] Intent to Ship: Make 'true' a truthy value for window.open boolean features

2022-03-04 Thread Rick Byers
Make true truthy, who could object to that? :-) LGTM2 Seriously though, I agree on the sentiment of the low compat risk. This feels arguably bugfix-level to me. But I agree with Daniel that stranger things have happened in the world of web compat, so as always please keep an ear open for any regre

Re: [blink-dev] Intent to Ship: Make 'true' a truthy value for window.open boolean features

2022-03-04 Thread Daniel Bratell
LGTM1. The feedback from Mozilla and WebKit is not of the 100% official kind, but I agree that this is a small enough change to not request more formal feedback than the feedback that already is there. (Also, "exceedingly unlikely", if I've learned anything about the web, it is that there is

[blink-dev] Re: Intent to Experiment: Capture handle

2022-03-04 Thread 'Elad Alon' via blink-dev
*Intent to extend experiment, I mean. On Friday, March 4, 2022 at 3:34:12 PM UTC+1 Elad Alon wrote: > Contact emailselad...@chromium.org > > Explainerhttps://github.com/WICG/capture-handle/blob/main/README.md > > Specificationhttps://wicg.github.io/capture-handle/ ("Identity" part) > > Summary >

[blink-dev] Intent to Experiment: Capture handle

2022-03-04 Thread 'Elad Alon' via blink-dev
Contact emailselada...@chromium.org Explainerhttps://github.com/WICG/capture-handle/blob/main/README.md Specificationhttps://wicg.github.io/capture-handle/ ("Identity" part) Summary We introduce a mechanism that allows an application to opt-in to exposing certain information to other applicatio