Re: [blink-dev] Intent to Ship: Dispatch selectionchange event per element

2024-06-13 Thread 'Gaurang Tandon' via blink-dev
Hi all! I believe this CL has an unintentional behavior change for elements inside shadow roots (open/closed). I have filed a detailed bug report here https://issues.chromium.org/issues/346898523 In brief, the issue is: when an element is inside a shadow root, then its selectionchange event

Re: [EXTERNAL] Re: [blink-dev] Web-Facing Change PSA: Write `image/svg+xml` content in UTF-8 format on Windows.

2024-06-13 Thread Jeffrey Yasskin
Thanks! On Thu, Jun 13, 2024 at 9:52 AM Anupam Snigdha wrote: > Thinking about it a little more, I think we need to change the spec text > to account for PNG images and other formats as well, so just having this > text in the spec for all formats doesn't make sense. Also, you're right > that it

Re: [EXTERNAL] Re: [blink-dev] Web-Facing Change PSA: Write `image/svg+xml` content in UTF-8 format on Windows.

2024-06-13 Thread 'Anupam Snigdha' via blink-dev
Thinking about it a little more, I think we need to change the spec text to account for PNG images and other formats as well, so just having this text in the spec for all formats doesn't make sense. Also, you're right that it doesn't describe the changes being proposed here. I filed a spec

Re: [blink-dev] PSA: Windows default CJK fonts changes

2024-06-13 Thread Koji Ishii
yiorsi, thank you for the suggestion. I'll add it to my list to investigate. On Thu, Jun 13, 2024 at 6:11 PM 一丝 wrote: > As I understand it, the font features of Source Han and Noto CJK are > almost the same. So should we fallback to Source Han when Noto CJK doesn't > exist? > > 在2024年6月12日星期三

Re: [blink-dev] Re: Intent to Ship: document.caretPositionFromPoint API

2024-06-13 Thread Daniel Bratell
LGTM3 /Daniel On 2024-06-13 10:56, Yoav Weiss (@Shopify) wrote: LGTM2 On Thu, Jun 13, 2024, 10:32 Chris Harrelson wrote: LGTM1 On Wed, Jun 12, 2024 at 10:26 PM 'Siye Liu' via blink-dev wrote: Yes, these tests will all pass if we enable the runtime flag

Re: [blink-dev] PSA: Windows default CJK fonts changes

2024-06-13 Thread 一丝
As I understand it, the font features of Source Han and Noto CJK are almost the same. So should we fallback to Source Han when Noto CJK doesn't exist? 在2024年6月12日星期三 UTC+8 12:10:08 写道: > Dominik: > >> Can you share some details in how this is implemented in terms of >> interfacing with the

Re: [blink-dev] Re: Intent to Ship: document.caretPositionFromPoint API

2024-06-13 Thread Chris Harrelson
LGTM1 On Wed, Jun 12, 2024 at 10:26 PM 'Siye Liu' via blink-dev < blink-dev@chromium.org> wrote: > Yes, these tests will all pass if we enable the runtime flag > `CaretPositionFromPoint`. > > The few Mozilla failures do represent their non-spec compliant behavior. > > Thanks, > Siye > > On

Re: [blink-dev] Re: Intent to Ship: document.caretPositionFromPoint API

2024-06-13 Thread Yoav Weiss (@Shopify)
LGTM2 On Thu, Jun 13, 2024, 10:32 Chris Harrelson wrote: > LGTM1 > > On Wed, Jun 12, 2024 at 10:26 PM 'Siye Liu' via blink-dev < > blink-dev@chromium.org> wrote: > >> Yes, these tests will all pass if we enable the runtime flag >> `CaretPositionFromPoint`. >> >> The few Mozilla failures do

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-06-13 Thread Chris Harrelson
LGTM1 based on the UseCounter being very low, but before shipping please update us on whether PayPal is not impacted. On Wed, Jun 12, 2024 at 10:56 PM 'Aaron Selya' via blink-dev < blink-dev@chromium.org> wrote: > Daniel, > My initial metrics were significantly higher due to the presence of a >

[blink-dev] Re: [LayerTreeView][RequestNewLayerTreeFrameSink] Nested infinite loops in render main thread

2024-06-13 Thread 'Lowell Liu' via blink-dev
This issue will cause process leakage and occupy huge memory resources, and no any states updated in the ticket https://issues.chromium.org/issues/345275130 for a week. On Friday, June 7, 2024 at 6:19:18 PM UTC+8 Lowell Liu wrote: > need your help, please take a look, will appreciate it. > >