Re: [blink-dev] Intent to Implement and Ship: aria-rowindextext and aria-colindextext

2024-06-17 Thread Vladimir Levin
LGTM1, thanks On Wed, Jun 12, 2024 at 2:35 PM 'Daniel Clark' via blink-dev < blink-dev@chromium.org> wrote: > *Contact emails* > > dan...@microsoft.com > > > > *Explainer* > > No formal explainer but https://github.com/w3c/aria/issues/667 discusses > use cases and alternatives. > > > > *Specifica

Re: [blink-dev] Re: Intent to Ship: document.caretPositionFromPoint API

2024-06-17 Thread Yoav Weiss (@Shopify)
On Mon, Jun 17, 2024 at 6:16 PM 'Siye Liu' via blink-dev < blink-dev@chromium.org> wrote: > TAG suggested we put the shadow roots in a dictionary with a `shadowRoots` > option (The API shape changed in spec > > after the TA

Re: [blink-dev] Re: Intent to Ship: document.caretPositionFromPoint API

2024-06-17 Thread 'Siye Liu' via blink-dev
TAG suggested we put the shadow roots in a dictionary with a `shadowRoots` option (The API shape changed in spec after the TAG review was filed). That's what Chromium implemented: document.idl - Chromium Code Search

Re: [blink-dev] Re: Intent to Ship: document.caretPositionFromPoint API

2024-06-17 Thread Yoav Weiss (@Shopify)
Note that the TAG just came back with some feedback regarding the API shape. Please address it before shipping. On Thu, Jun 13, 2024 at 2:34 PM Daniel Bratell wrote: > LGTM3 > > /Daniel > On 2024-06-13 10:56, Yoav Weiss (@Shopify) wrote: > > LGTM2 > > On Thu, Jun 13, 2024, 10:32 Chris Harrelson