[blink-dev] Re: fetch API and filesystem: URLs (a Manifest v3 migration blocker)

2024-07-09 Thread Adam Rice
Interesting point. It affects the whole render process. On Tue, 9 Jul 2024 at 10:13, Nigel Tao wrote: > On Mon, Jul 8, 2024 at 5:05 PM Adam Rice wrote: > > It's possible to enable schemes for Fetch using code similar to > https://source.chromium.org/chromium/chromium/src/+/mai

[blink-dev] Re: fetch API and filesystem: URLs (a Manifest v3 migration blocker)

2024-07-08 Thread Adam Rice
It's possible to enable schemes for Fetch using code similar to https://source.chromium.org/chromium/chromium/src/+/main:extensions/renderer/dispatcher.cc?q=%22WebSecurityPolicy::RegisterURLSchemeAsSupportingFetchAPI(extension_scheme);%22=chromium%2Fchromium%2Fsrc, however it would require

Re: [blink-dev] Re: Intent to Ship: WebSocketStream

2024-03-04 Thread Adam Rice
:50, Chris Harrelson >> wrote: >> >>> Hi, >>> >>> Any reason the PR for the spec hasn't landed yet? >>> >>> On Thu, Feb 15, 2024 at 7:54 AM Mike Taylor >>> wrote: >>> >>>> Thank you - LGTM1 >>>&g

Re: [blink-dev] Re: Intent to Ship: WebSocketStream

2024-02-16 Thread Adam Rice
> > On Thu, Feb 15, 2024 at 7:54 AM Mike Taylor > wrote: > >> Thank you - LGTM1 >> On 2/15/24 7:16 AM, Adam Rice wrote: >> >> Thanks Mike, >> >> I have requested the approvals. Sorry for the delay, I didn't understand >> the interface. >>

Re: [blink-dev] Re: Intent to Ship: WebSocketStream

2024-02-15 Thread Adam Rice
y Adam, >> >> Glad to see this moving forward! Has there been a summary somewhere of >> the OT feedback? Also, we noted that the other reviews were marked as >> unstarted in chromestatus; we will likely hold off voting until those are >> in flight. >>

[blink-dev] Re: Intent to Ship: WebSocketStream

2024-02-07 Thread Adam Rice
a summary somewhere of the > OT feedback? Also, we noted that the other reviews were marked as unstarted > in chromestatus; we will likely hold off voting until those are in flight. > > Thanks! > > On Tuesday, February 6, 2024 at 1:43:46 PM UTC-8 Adam Rice wrote: > >&

[blink-dev] Intent to Ship: WebSocketStream

2024-02-06 Thread Adam Rice
Contact emailsri...@chromium.org Explainer https://github.com/ricea/websocketstream-explainer/blob/master/README.md https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit Specificationhttps://github.com/whatwg/websockets/pull/48 Design docs

[blink-dev] PSA: WebSocketStream API change

2023-08-01 Thread Adam Rice
WebSocketStream is not a shipped API so normally we wouldn't announce changes, but I know some people are trying it out using the experimental flag, so I am sending this PSA. >From Chromium version 117.0.5914.0 onwards, the "connection" attribute has been renamed to "opened". Where previously

Re: [blink-dev] Intent to Ship: RFC 7616 Digest auth: Support SHA-256, SHA-512-256 and user hashing

2023-06-30 Thread Adam Rice
counters to know how common these digests > are, but given that the code is fully contained in net/ this might be a bit > tricky. Maybe +Adam Rice and team would be able to > help with adding some metrics there? That's not a blocker for this intent, > but would help shed light on overall usage of

Re: [blink-dev] Intent to Prototype: Zstd Content-Encoding

2023-06-27 Thread Adam Rice
05 PM PhistucK wrote: >>>> >>>>> If/when shipping, just remember to add this to the list of "Accepted >>>>> Content-Encodings" that shows up on the developer tools, under the >>>>> "Network >>>>&

Re: [blink-dev] Intent to Prototype: Zstd Content-Encoding

2023-06-21 Thread Adam Rice
> > Drive by question: Given that the codec is going to be in the browser, are > there plans to surface this up to CompressionStreams? (same question > applies for Brotli, I suppose) For the zstd Content-Encoding, we will only be linking in the decompression part of the zstd library. But for

Re: [blink-dev] Intent to Ship: BYOB support for Fetch

2023-06-07 Thread Adam Rice
> > I agree that these patterns are likely to be rare, making this a low risk > endeavor. Please still make sure the flags are working as expected, and > slowly roll this out, just to be on the safe side. Is it sufficient to roll-out the new cloning behaviour and the BYOB support separately, or

Re: [blink-dev] Timeout for some websocket tests

2022-11-28 Thread Adam Rice
This is probably caused by tests interfering with each other, either by exhausting CPU or network resources. You could try running running run_web_tests with a lower value of -j, but of course this will make it slower. Alternatively, you could increase the value of --num-retries to ignore more

Re: [chromium-dev] Re: [blink-dev] Inactive OWNERS cleanup

2022-07-29 Thread Adam Rice
+1 to removing inactive OWNERS. It should not require insider knowledge to find someone to review your CL. While it would be great if our tools were better at handling OOO OWNERS, the current state of affairs is that they aren't. It is easy enough for someone to re-add themselves to OWNERS when

Re: [blink-dev] Intent to Prototype and Ship: Response.json()

2022-06-23 Thread Adam Rice
>> >>>> LGTM1 >>>> >>>> On Tue, May 31, 2022 at 11:08 PM Yoav Weiss >>>> wrote: >>>> >>>>> >>>>> >>>>> On Tue, May 31, 2022 at 4:08 AM Adam Rice wrote: >>>>> >&g

[blink-dev] Intent to Prototype and Ship: Response.json()

2022-05-30 Thread Adam Rice
Contact emailsri...@chromium.org, yhir...@chromium.org Explainer https://docs.google.com/document/d/1dTycWmyxLZNGTBW93fvtf1IQahx-vNwgu94yT1x9K50/edit Specificationhttps://fetch.spec.whatwg.org/#ref-for-dom-response-json Summary Improves ergonomics for creating JSON Response objects. The

Re: [blink-dev] Intent to Experiment: Load common payloads from privacy-preserving single-keyed cache

2022-04-28 Thread Adam Rice
; > On Wed, Apr 27, 2022 at 2:30 AM Adam Rice wrote: > >> What is an 'off-by-default experiment'? Is that a dev trial flag? >> >> >> Just an ordinary experiment, behind a flag which is off-by-default. So >> most users get the default behaviour (no single

Re: [blink-dev] Intent to Experiment: Load common payloads from privacy-preserving single-keyed cache

2022-04-27 Thread Adam Rice
> > What is an 'off-by-default experiment'? Is that a dev trial flag? Just an ordinary experiment, behind a flag which is off-by-default. So most users get the default behaviour (no single-keyed cache), except for those in the experimental group. On Wed, 27 Apr 2022 at 00:50, Joe Medley wrote:

Re: [blink-dev] PSA: Readable Byte Streams updates in Blink Implementation

2021-10-13 Thread Adam Rice
Yes. The only use case of respondWithNewView() is when you've transferred the ArrayBuffer and so you can't use respond(). Most people will never need it. On Thu, 14 Oct 2021 at 01:59, Reilly Grant wrote: > This is somewhat of a tangent but I'm curious what the use case for >