Re: [blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-09-02 Thread Ane Diaz De Tuesta
Hello, I’ve addressed the comments on my review. As mentioned in one of them, I’ve had some difficulties running tests locally due to issues with my machine. I think it would be best to run try jobs to identify any remaining modifications needed before the CL can be merged. Could you please r

Re: [blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-08-08 Thread Michal Mocny
Absolutely-- fantastic of you to put in the effort to contribute! Enjoy your time off. -Michal On Fri, Aug 8, 2025 at 1:43 PM Ane Diaz De Tuesta wrote: > Hello, > Thanks for your code review and your feedback! > > I am currently on PTO until the last week of August, and I'll address your > com

Re: [blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-08-08 Thread Ane Diaz De Tuesta
Hello, Thanks for your code review and your feedback! I am currently on PTO until the last week of August, and I'll address your comments once I'm back. Many of the issues in my patch stem from my lack of familiarity with the codebase, the libraries and the language, I really appreciate your guida

Re: [blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-08-08 Thread Michal Mocny
(Sorry, was OOO last week) I think the CL is ready for landing (~few more small review comments and potential test updates). The feature flag right now is marked for Origin Trial, but I don't think OT is a good fit for this change. Instead we can set the feature as experimental, publicize the pr

Re: [blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-08-04 Thread Ane Diaz De Tuesta
Thanks a lot for the clarifications! Sounds good, I’ll wait for Michal’s input here, and if he’s unavailable, I’ll look for another code OWNER to approve the CL. By the way, in that case, what’s the recommended way to assign someone else as a reviewer? I’m also aligned with the idea of being tran

Re: [blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-08-01 Thread Rick Byers
In terms of the process, yes we do just land CLs behind flags (off by default, potentially turned on by the enable-experimental-web-platform-features flag). No approval is needed here for that, just from code OWNERS reviewing the CL (probably Michal in this case, but could be others too if he's bus

Re: [blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-08-01 Thread Ane Diaz De Tuesta
Thanks, I completely agree, the more we can highlight interoperability and cross-browser compatibility, the better, especially as we move toward the *Intent to Ship* stage. My plan is to go step by step: first land the fix, then progressively enable the flag, assuming that’s aligned with how

Re: [blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-07-31 Thread Daniel Bratell
I agree that it seems like a good idea, and the only concern would be whether it will break things. It sounds like Michal Mocny has been on top of things, but what were his findings? Once it comes to the shipping decision, the more you can say about interoperability and compatibility, the bett

Re: [blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-07-31 Thread Ane Diaz De Tuesta
Hello, It’s been about 10 days since I shared the Intent to Prototype proposal, and from what I gather, it has been generally well received. As I’m not entirely familiar with the process, I’d like to suggest the following next steps—unless there are any objections: - Merge the CL

Re: [blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-07-23 Thread Michal Mocny
I do suspect this was more of an oversight than a specific decision, and feedback from developers seems to align with Ane Diaz: most are having to work around this. However, there are clients out there who now depend on this and we are reaching out to see if it's less of a total headache to fix in

Re: [blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-07-22 Thread Rick Byers
Sounds like a valuable improvement, thank you! I see you're talking with @mmocny on the CL , that's great. I wonder if this was just an oversight in our initial design? Seems like a bug to me. Think we can just switch it (and put t

[blink-dev] [Intent to Prototype] Layout Instability Attribution in CSS Pixels

2025-07-22 Thread Ane Diaz De Tuesta
Hi all, I'd like to announce an Intent to Prototype for: - *Feature name:* Layout Instability Attribution in CSS Pixels - *Contact:* anediaz@gmail - *Explainer:* https://github.com/anediaz/layout-shift-attribution-in-css-pixels/blob/main/Explainer.md - *Summary:* The Layout