Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-20 Thread Rick Byers
Thanks for the great analysis! LGTM3 with a killswitch in case we predicted wrong. On Thu, Apr 20, 2023 at 9:57 AM Philip Jägenstedt wrote: > LGTM2, thank you Mathias for the detailed analysis! > > On Thu, Apr 20, 2023 at 3:48 PM Yoav Weiss wrote: > >> LGTM1 to ship with a killswitch flag, just

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-20 Thread Philip Jägenstedt
LGTM2, thank you Mathias for the detailed analysis! On Thu, Apr 20, 2023 at 3:48 PM Yoav Weiss wrote: > LGTM1 to ship with a killswitch flag, just in case. > > Thanks for the thorough analysis! > > On Thu, Apr 20, 2023 at 3:41 PM Mathias Bynens wrote: > >> I’ve continued analyzing UKM results a

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-20 Thread Philip Jägenstedt
On Wed, Apr 19, 2023 at 10:28 PM Rick Byers wrote: > On Wed, Apr 19, 2023 at 3:41 PM Philip Jägenstedt > wrote: > >> I wonder if we can get enough confidence with less work than >> investigating 40 randomly chosen sites from UseCounter hits. >> >> This is a population proportion problem, and >>

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-20 Thread 'Yoav Weiss' via blink-dev
LGTM1 to ship with a killswitch flag, just in case. Thanks for the thorough analysis! On Thu, Apr 20, 2023 at 3:41 PM Mathias Bynens wrote: > I’ve continued analyzing UKM results and have now reached n=40 as Rick > suggested: > > | origin | link to analysis > |

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-20 Thread 'Mathias Bynens' via blink-dev
I’ve continued analyzing UKM results and have now reached n=40 as Rick suggested: | origin | link to analysis | continues to work with the change? | | :--- | : | :- | |

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-20 Thread 'Mathias Bynens' via blink-dev
On Wed, Apr 19, 2023 at 9:41 PM Philip Jägenstedt wrote: > I wonder if we can get enough confidence with less work than investigating > 40 randomly chosen sites from UseCounter hits. > > This is a population proportion problem, and > https://sample-size.net/confidence-interval-proportion/ is a us

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-19 Thread 'nightpool' via blink-dev
I will say personally, as an author, I am generally accustomed to using special characters in my regex character classes freely, and hearing that the HTML spec is making a backwards incompatible breaking change that would prevent me from doing so is kind of surprising, and personally i would pr

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-19 Thread Rick Byers
On Wed, Apr 19, 2023 at 3:41 PM Philip Jägenstedt wrote: > I wonder if we can get enough confidence with less work than investigating > 40 randomly chosen sites from UseCounter hits. > > This is a population proportion problem, and > https://sample-size.net/confidence-interval-proportion/ is a us

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-19 Thread Philip Jägenstedt
I wonder if we can get enough confidence with less work than investigating 40 randomly chosen sites from UseCounter hits. This is a population proportion problem, and https://sample-size.net/confidence-interval-proportion/ is a useful tool. If you check 40 cases and find no breakage (N=40, x=0) th

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-19 Thread 'Mathias Bynens' via blink-dev
Thanks for the guidance, Rick. I’ve prepared a CL moving the flag to status=experimental and I can commit to investigating 40 unique UseCounter hits and summarizing my findings. Fingers crossed the trend of “no actual breakage dete

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-19 Thread Rick Byers
Thanks for doing a thorough compat analysis of this Mathias. I can totally see this being one where all the examples we can find don't seem to cause breakage in practice. I know it's a lot, but if we looked at 40 random examples and found none of them to break, that would suggest an upper bound of

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-17 Thread 'Mathias Bynens' via blink-dev
So far, none of the UseCounter hits I investigated constitute any actual breakage. The vast majority of hits seem to be login forms backed by server-side validation. I’ll keep looking though. In the meantime, this feature is now

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-05 Thread 'Mathias Bynens' via blink-dev
On Wed, Apr 5, 2023 at 5:23 PM Alex Russell wrote: > I don't understand why TAG review is not applicable for this intent. > Fair enough. I’ve filed a TAG review request here: https://github.com/w3ctag/design-reviews/issues/832 I’ll update the ChromeStatus entry to refer to it. On Tuesday, April

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-05 Thread Alex Russell
I don't understand why TAG review is not applicable for this intent. On Tuesday, April 4, 2023 at 5:21:16 AM UTC-7 mt...@google.com wrote: > Thanks to the UseCounter + UKM + M112 hitting Stable, more results are > starting to come in. I’ll be collecting public examples of potential > incompatib

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-04 Thread 'Mathias Bynens' via blink-dev
Thanks to the UseCounter + UKM + M112 hitting Stable, more results are starting to come in. I’ll be collecting public examples of potential incompatibilities here: https://bugs.chromium.org/p/chromium/issues/detail?id=1412729#c11 So far 0 out of the 2 examples cause any actual breakage — fingers cr

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-04-03 Thread Philip Jägenstedt
I took a look at https://github.com/whatwg/html/pull/7908 and it looks like there's agreement to merge it, but it's waiting on this intent to be approved. Normally we block in the other direction, but that's fine, as long as the spec change is merged. Looks like there's broad support for this chan

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-03-31 Thread 'Mathias Bynens' via blink-dev
On Fri, Mar 31, 2023 at 4:35 PM Mike Taylor wrote: > Hey Mathias, > On 3/31/23 5:56 AM, Mathias Bynens wrote: > > Contact emails > > math...@chromium.org > > Specification > > https://github.com/whatwg/html/pull/7908 > > Summary > > The attribute allows developers to specify a regular > expressi

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-03-31 Thread Mike Taylor
Hey Mathias, On 3/31/23 5:56 AM, Mathias Bynens wrote: Contact emails math...@chromium.org Specification https://github.com/whatwg/html/pull/7908 Summary The attribute allows developers to specify a regular expression

[blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

2023-03-31 Thread Mathias Bynens
Contact emails math...@chromium.org Specification https://github.com/whatwg/html/pull/7908 Summary The attribute allows developers to specify a regular expression pattern against which the input’s values are checked for validity. Part number: When the pattern attribute was first i