Re: [blink-dev] Intent to Re-implement and Ship: CSS Font Loading API - FontFaceSet: check() method

2023-10-18 Thread ChangSeok Oh
Gecko got a ticket for that failure, WebKit passed the tests when I ran the tests with ToT. Thanks for your LGTMs! On Wednesday, October 18, 2023 at 12:21:01 AM UTC-7 yoav...@chromium.org wrote: > LGTM3 > > Thanks for clarifying. Please file implementation bugs for these failures, > if ones

Re: [blink-dev] Intent to Re-implement and Ship: CSS Font Loading API - FontFaceSet: check() method

2023-10-18 Thread Yoav Weiss
LGTM3 Thanks for clarifying. Please file implementation bugs for these failures, if ones don't already exist. On Tue, Oct 17, 2023 at 11:16 PM ChangSeok Oh wrote: > Hi Yoav, > > Yes, Safari and Firefox support the check method [1], and I confirmed it. > The test failures are due to other

Re: [blink-dev] Intent to Re-implement and Ship: CSS Font Loading API - FontFaceSet: check() method

2023-10-17 Thread ChangSeok Oh
Hi Yoav, Yes, Safari and Firefox support the check method [1], and I confirmed it. The test failures are due to other factors (e.g., pixel mismatches), not FontFaceSet::check(). Sub-tests on the check() method have passed. [1] https://caniuse.com/mdn-api_fontfaceset_check -- ChangSeok > On

Re: [blink-dev] Intent to Re-implement and Ship: CSS Font Loading API - FontFaceSet: check() method

2023-10-17 Thread Yoav Weiss
On Mon, Oct 16, 2023 at 8:15 PM Mike Taylor wrote: > LGTM2 > On 10/16/23 1:35 PM, Alex Russell wrote: > > LGTM1 > > On Sun, Oct 15, 2023 at 1:01 PM ChangSeok Oh wrote: > >> Contact emails >> changseok...@bytedance.com, shivami...@gmail.com >> >> Specification >>

Re: [blink-dev] Intent to Re-implement and Ship: CSS Font Loading API - FontFaceSet: check() method

2023-10-16 Thread Mike Taylor
LGTM2 On 10/16/23 1:35 PM, Alex Russell wrote: LGTM1 On Sun, Oct 15, 2023 at 1:01 PM ChangSeok Oh wrote: Contact emails changseok...@bytedance.com,shivami...@gmail.com Specification https://drafts.csswg.org/css-font-loading/#font-face-set-check Summary The

Re: [blink-dev] Intent to Re-implement and Ship: CSS Font Loading API - FontFaceSet: check() method

2023-10-16 Thread Alex Russell
LGTM1 On Sun, Oct 15, 2023 at 1:01 PM ChangSeok Oh wrote: > Contact emails > changseok...@bytedance.com, shivami...@gmail.com > > Specification > https://drafts.csswg.org/css-font-loading/#font-face-set-check > > Summary > > The FontFaceSet's check() function verifies whether it's possible to >

[blink-dev] Intent to Re-implement and Ship: CSS Font Loading API - FontFaceSet: check() method

2023-10-15 Thread ChangSeok Oh
Contact emails changseok...@bytedance.com, shivami...@gmail.com Specification https://drafts.csswg.org/css-font-loading/#font-face-set-check Summary The FontFaceSet's check() function verifies whether it's possible to display text using the specified fonts without attempting to utilize fonts