Re: [blink-dev] Intent to Remove: ImageEncodeOptions colorSpace and pixelFormat

2022-11-17 Thread Rick Byers
Hah, awesome! These "we accidentally web exposed this for years" threads always scare me a little, glad this turned out not to be one after all! Rick On Thu, Nov 17, 2022 at 7:19 AM Christopher Cameron wrote: > On Thu, Nov 17, 2022 at 12:42 PM Yoav Weiss > wrote: > >> If this is indeed dead co

Re: [blink-dev] Intent to Remove: ImageEncodeOptions colorSpace and pixelFormat

2022-11-17 Thread 'Christopher Cameron' via blink-dev
On Thu, Nov 17, 2022 at 12:42 PM Yoav Weiss wrote: > If this is indeed dead code, then this change is not web exposed, and > hence no LGTMs are needed > SGTM. > Can you outline how this test is testing that we're ignoring these > parameters? I'm not sure I get it.. Also, Safari seems to be fai

Re: [blink-dev] Intent to Remove: ImageEncodeOptions colorSpace and pixelFormat

2022-11-17 Thread Yoav Weiss
If this is indeed dead code, then this change is not web exposed, and hence no LGTMs are needed On Thu, Nov 17, 2022 at 11:12 AM 'Christopher Cameron' via blink-dev < blink-dev@chromium.org> wrote: > On Wed, Nov 16, 2022 at 8:57 PM Mike Taylor > wrote: > >> If we're not 100% confident in the saf

Re: [blink-dev] Intent to Remove: ImageEncodeOptions colorSpace and pixelFormat

2022-11-17 Thread 'Christopher Cameron' via blink-dev
On Wed, Nov 16, 2022 at 8:57 PM Mike Taylor wrote: > If we're not 100% confident in the safety of removal then I'd suggest >> landing a simple UseCounter now, and removing in the next milestone. You >> could probably even get the UseCounter merged into M109 if you want, then >> land removal for M

Re: [blink-dev] Intent to Remove: ImageEncodeOptions colorSpace and pixelFormat

2022-11-16 Thread Mike Taylor
On Wed, Nov 16, 2022, 7:30 PM Rick Byers wrote: On Tue, Nov 15, 2022 at 3:18 PM 'Christopher Cameron' via blink-dev wrote: On Tue, Nov 15, 2022 at 7:23 PM Mike Taylor wrote: On 11/15/22 11:21 AM, 'Christopher Cameron' via blink-dev wrote:

Re: [blink-dev] Intent to Remove: ImageEncodeOptions colorSpace and pixelFormat

2022-11-16 Thread Rick Byers
On Tue, Nov 15, 2022 at 3:18 PM 'Christopher Cameron' via blink-dev < blink-dev@chromium.org> wrote: > On Tue, Nov 15, 2022 at 7:23 PM Mike Taylor > wrote: > >> On 11/15/22 11:21 AM, 'Christopher Cameron' via blink-dev wrote: >> >> *Contact email:* >> ccame...@chromium.org >> >> *Explainer:* None

Re: [blink-dev] Intent to Remove: ImageEncodeOptions colorSpace and pixelFormat

2022-11-15 Thread 'Christopher Cameron' via blink-dev
On Tue, Nov 15, 2022 at 7:23 PM Mike Taylor wrote: > On 11/15/22 11:21 AM, 'Christopher Cameron' via blink-dev wrote: > > *Contact email:* > ccame...@chromium.org > > *Explainer:* None > *Specification:* None > > *Summary:* > These fields were accidentally exposed to the web in crrev.com/562990 b

Re: [blink-dev] Intent to Remove: ImageEncodeOptions colorSpace and pixelFormat

2022-11-15 Thread Mike Taylor
On 11/15/22 11:21 AM, 'Christopher Cameron' via blink-dev wrote: *Contact email:* ccame...@chromium.org *Explainer:* None *Specification:* None *Summary:* These fields were accidentally exposed to the web in crrev.com/562990  by way of crrev.com/427153

[blink-dev] Intent to Remove: ImageEncodeOptions colorSpace and pixelFormat

2022-11-15 Thread 'Christopher Cameron' via blink-dev
*Contact email:* ccame...@chromium.org *Explainer:* None *Specification:* None *Summary:* These fields were accidentally exposed to the web in crrev.com/562990 by way of crrev.com/427153. They are not part of any specification. These fields allow OffscreenCanvas::convertToBlob to specify a targe