[blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-03-11 Thread Aaron Selya
Contact emails se...@chromium.org, dylancut...@chromium.org, kaustub...@chromium.org Explainer Keying of "CHIPS" cookies should align with other state: Specification Add cross-site ancestor chain bit to spec: https://gith

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-03-12 Thread Vladimir Levin
On Mon, Mar 11, 2024 at 1:42 PM Aaron Selya wrote: > Contact emails > > se...@chromium.org, dylancut...@chromium.org, kaustub...@chromium.org > > > Explainer > > Keying of "CHIPS" cookies should align with other state: > > > >

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-03-12 Thread 'Aaron Selya' via blink-dev
> > The first mitigation listed here is to migrate existing > partitioned cookies to include the new bit, and the second mitigation is to > have a flag that can disable this feature. Would disabling the feature also > include migrating the existing cookies back to exclude the new bit? > Disabling

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-03-13 Thread Yoav Weiss (@Shopify)
On Tue, Mar 12, 2024 at 4:46 PM 'Aaron Selya' via blink-dev < blink-dev@chromium.org> wrote: > The first mitigation listed here is to migrate existing >> partitioned cookies to include the new bit, and the second mitigation is to >> have a flag that can disable this feature. Would disabling the fe

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-03-13 Thread Yoav Weiss (@Shopify)
Also, can you flip on the relevant review gates in chromestatus.com? On Wed, Mar 13, 2024 at 11:24 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > > > On Tue, Mar 12, 2024 at 4:46 PM 'Aaron Selya' via blink-dev < > blink-dev@chromium.org> wrote: > >> The first mitigation listed here i

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-03-13 Thread 'Aaron Selya' via blink-dev
The flag is a base::features flag named kAncestorChainBitEnabledInPartitionedCookies. Updated the review gates on chromestatus.com On Wed, Mar 13, 2024 at 11:25 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > Also, can you flip on the relevant review gates in chromestatus.com? > > On

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-03-19 Thread Yoav Weiss (@Shopify)
OK, so just to summarize my understanding: - We expect this to have some impact on 0.032% of page views - We have a Finch flag that can be used as a kill switch in case we see lots of breakage in the wild - Developers can get around this deprecation by changing their cookies to be "

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-03-19 Thread Mike Taylor
It would also be helpful to discuss what breakage looks like in this case. Would it be a one-time loss of state (i.e., have to log in again), or something different? On 3/19/24 5:08 AM, Yoav Weiss (@Shopify) wrote: OK, so just to summarize my understanding: * We expect this to have some imp

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-03-19 Thread 'Aaron Selya' via blink-dev
Yoav, your understanding is correct. I'm still in the process of finalizing the implementation. Once that is done, I'll audit some sites that metrics have indicated will experience breakage and report back my findings. On Tue, Mar 19, 2024 at 8:52 AM Mike Taylor wrote: > It would also be helpfu

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-05-01 Thread 'Aaron Selya' via blink-dev
My apologies for the delay in following up on this. When I finished my initial implementation and got to the point where I could begin testing, I found that my metrics were being flooded with a cookie named, "receive-cookie-deprication". After doing some research and testing I learned that this co

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-05-03 Thread Yoav Weiss (@Shopify)
Thanks for diving into this!! I guess the scariest bit here would be paypal losing a cookie in the redirect. Even if you didn't find a visible impact in your testing, they may not be exhaustive, and breakage there feels riskier than in other mentioned domains. Have you tried to reach out to Paypa

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-05-03 Thread 'Aaron Selya' via blink-dev
Thank you for suggesting a deeper dive into this Yoav as I might not have discovered the significant impact that the "receive-cookie-deprication" cookies were having on my metrics without your prompting. I've reached out to some engineers at Paypal and hopefully they'll get back to me sometime nex

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-05-22 Thread Yoav Weiss (@Shopify)
Any news from Paypal? On Friday, May 3, 2024 at 7:15:58 PM UTC+2 Aaron Selya wrote: > Thank you for suggesting a deeper dive into this Yoav as I might not have > discovered the significant impact that the "receive-cookie-deprication" > cookies were having on my metrics without your prompting.

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-05-22 Thread 'Aaron Selya' via blink-dev
Had a good initial conversation with them on Monday letting them know about the issue. They're going to do some testing with the feature enabled to try and gauge the impact the feature will have on their backend. I'm hopeful that they'll give us an update by early next week. On Wed, May 22, 2024 a

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-05-22 Thread Chris Harrelson
Please also fill out the Testing section on chromestatus.com. On Wed, May 22, 2024 at 7:50 AM 'Aaron Selya' via blink-dev < blink-dev@chromium.org> wrote: > Had a good initial conversation with them on Monday letting them know > about the issue. They're going to do some testing with the feature e

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-05-30 Thread 'Aaron Selya' via blink-dev
@Chris, completed the testing section as requested. @Yoav, paypal requested a test site they could use for determining independently if the feature was activated for their testing. I provided them with a glitch.me site that shows if an A1->B->A2 embed is

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-06-06 Thread 'Aaron Selya' via blink-dev
I haven't heard back from Paypal yet, I'm planning on following up with them today to see if they have any updates on their testing. Besides hearing back from them, is there any other information that's holding up LGTM? On Thu, May 30, 2024 at 1:53 PM Aaron Selya wrote: > @Chris, completed the

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-06-12 Thread 'Aaron Selya' via blink-dev
Daniel, My initial metrics were significantly higher due to the presence of a cookie named “receive-cookie-deprication”. This is a cookie , Google is using to

Re: [blink-dev] Intent to Ship: Adding Cross-site Ancestor Chain Bit to CHIPS Partition Key

2024-06-13 Thread Chris Harrelson
LGTM1 based on the UseCounter being very low, but before shipping please update us on whether PayPal is not impacted. On Wed, Jun 12, 2024 at 10:56 PM 'Aaron Selya' via blink-dev < blink-dev@chromium.org> wrote: > Daniel, > My initial metrics were significantly higher due to the presence of a > c