Re: [blink-dev] Intent to Ship: BYOB support for Fetch

2023-06-07 Thread slightlyoff via Chromestatus
LGTM3 -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chro

Re: [blink-dev] Intent to Ship: BYOB support for Fetch

2023-06-07 Thread Yoav Weiss
On Wed, Jun 7, 2023 at 10:01 AM Adam Rice wrote: > I agree that these patterns are likely to be rare, making this a low risk >> endeavor. Please still make sure the flags are working as expected, and >> slowly roll this out, just to be on the safe side. > > > Is it sufficient to roll-out the new

Re: [blink-dev] Intent to Ship: BYOB support for Fetch

2023-06-07 Thread Adam Rice
> > I agree that these patterns are likely to be rare, making this a low risk > endeavor. Please still make sure the flags are working as expected, and > slowly roll this out, just to be on the safe side. Is it sufficient to roll-out the new cloning behaviour and the BYOB support separately, or d

Re: [blink-dev] Intent to Ship: BYOB support for Fetch

2023-06-07 Thread Yoav Weiss
LGTM2 I agree that these patterns are likely to be rare, making this a low risk endeavor. Please still make sure the flags are working as expected, and slowly roll this out, just to be on the safe side. On Tue, Jun 6, 2023 at 8:27 AM Nidhi Jaju wrote: > > > On Tue, Jun 6, 2023 at 1:01 PM Yoav W

Re: [blink-dev] Intent to Ship: BYOB support for Fetch

2023-06-05 Thread Nidhi Jaju
On Tue, Jun 6, 2023 at 1:01 PM Yoav Weiss wrote: > > > On Monday, June 5, 2023 at 1:13:11 PM UTC+2 Nidhi Jaju wrote: > > Thank you, Mike and Yoav! > > I filed a standards position request with WebKit, and they are supportive > as well: https://github.com/WebKit/standards-positions/issues/194. > >

Re: [blink-dev] Intent to Ship: BYOB support for Fetch

2023-06-05 Thread Yoav Weiss
On Monday, June 5, 2023 at 1:13:11 PM UTC+2 Nidhi Jaju wrote: Thank you, Mike and Yoav! I filed a standards position request with WebKit, and they are supportive as well: https://github.com/WebKit/standards-positions/issues/194. That's great!! On Wed, May 31, 2023 at 9:33 PM Yoav Weiss

Re: [blink-dev] Intent to Ship: BYOB support for Fetch

2023-06-05 Thread Nidhi Jaju
Thank you, Mike and Yoav! I filed a standards position request with WebKit, and they are supportive as well: https://github.com/WebKit/standards-positions/issues/194. On Wed, May 31, 2023 at 9:33 PM Yoav Weiss wrote: > Thanks for aligning with Firefox here! > > On Fri, May 26, 2023 at 5:32 AM N

Re: [blink-dev] Intent to Ship: BYOB support for Fetch

2023-05-31 Thread Yoav Weiss
Thanks for aligning with Firefox here! On Fri, May 26, 2023 at 5:32 AM Nidhi Jaju wrote: > Contact emailsnidhij...@chromium.org > > ExplainerNone > > Specificationhttps://fetch.spec.whatwg.org/#http-network-fetch > > Summary > > Makes Response.body be a readable byte stream instead of a "default

Re: [blink-dev] Intent to Ship: BYOB support for Fetch

2023-05-31 Thread Mike West
LGTM1. Following along with Mozilla's long-standing implementation SGTM, and obviates the need for a TAG review. It would be ideal to file an official standards position issue with WebKit, however, to make sure they understand that we do intend to ship this and can incorporate that information int

[blink-dev] Intent to Ship: BYOB support for Fetch

2023-05-26 Thread Nidhi Jaju
Contact emailsnidhij...@chromium.org ExplainerNone Specificationhttps://fetch.spec.whatwg.org/#http-network-fetch Summary Makes Response.body be a readable byte stream instead of a "default" readable stream. This enables it to be used with bring-your-own-buffer (BYOB) readers, reducing garbage