Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-04-10 Thread fantasai
On 4/8/23 05:15, Jonathan Kew wrote: Looking at the webkit tests, I"m concerned that some of them may conflict with the spec (as I understand it), and this presumably reflects an issue with webkit's implementation. [...] and BCP47 specifically mentions that the language tags described in this

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-04-08 Thread Jonathan Kew
Looking at the webkit tests, I"m concerned that some of them may conflict with the spec (as I understand it), and this presumably reflects an issue with webkit's implementation. Specifically, in https://github.com/WebKit/WebKit/blob/main/LayoutTests/fast/selectors/lang-extended-filtering.html

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-04-05 Thread Daniel Bratell
Make that LGTM3, after Philip's LGTM2 /Daniel On 2023-04-05 17:42, Daniel Bratell wrote: LGTM2 /Daniel On 2023-04-05 05:58, Yoav Weiss wrote: LGTM1 once this is WPT tested with good coverage and our shipped behavior matches both WebKit and the spec. Please get back to this thread if e.g. t

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-04-05 Thread Daniel Bratell
LGTM2 /Daniel On 2023-04-05 05:58, Yoav Weiss wrote: LGTM1 once this is WPT tested with good coverage and our shipped behavior matches both WebKit and the spec. Please get back to this thread if e.g. the implemented WebKit behavior varies from the specified one. On Thu, Mar 30, 2023 at 9:09

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-04-05 Thread Philip Jägenstedt
LGTM2, and thanks for taking another look over the tests and ensuring solid coverage in WPT! On Wed, Apr 5, 2023 at 5:58 AM Yoav Weiss wrote: > LGTM1 once this is WPT tested with good coverage and our shipped behavior > matches both WebKit and the spec. Please get back to this thread if e.g. > t

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-04-04 Thread Yoav Weiss
LGTM1 once this is WPT tested with good coverage and our shipped behavior matches both WebKit and the spec. Please get back to this thread if e.g. the implemented WebKit behavior varies from the specified one. On Thu, Mar 30, 2023 at 9:09 AM Roger Zanoni wrote: > Hi Philip, thanks for looking f

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-03-30 Thread Roger Zanoni
Hi Philip, thanks for looking for the tests, they are relevant but they don't cover some cases, like implicit wildcard matching with more than one language subtags, private singleton matching I think we should add more cases to wpt tests targeting specific level4 matching logic, like the cases

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-03-29 Thread Roger Zanoni
Hi Yoav, thanks for checking, I will answer inline On Friday, March 17, 2023 at 10:59:14 AM UTC+1 yoav...@chromium.org wrote: On Thu, Mar 16, 2023 at 11:09 AM Roger Zanoni wrote: Contact emails rza...@igalia.com Explainer https://github.com/rogerzanoni/docs/tree/main/lang-level-4 Specificati

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-03-29 Thread Philip Jägenstedt
Hi Roger, I took a look for the tests, and am wondering if the tests added here are for Level 4? https://github.com/web-platform-tests/wpt/pull/37950 At least some of them are already passing in Chrome Dev (with experimental features enabled), but not Chrome stable, so some of these tests seem re

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-03-17 Thread Yoav Weiss
On Thu, Mar 16, 2023 at 11:09 AM Roger Zanoni wrote: > Contact emails rzan...@igalia.com > > Explainer https://github.com/rogerzanoni/docs/tree/main/lang-level-4 > > Specification https://www.w3.org/TR/selectors-4/#the-lang-pseudo > > Summary > > The :lang CSS pseudo-class currently matches eleme

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-03-16 Thread Mustafa Teke
16 Mar 2023 Per, saat 13:09 tarihinde Roger Zanoni şunu yazdı: > Contact emails rzan...@igalia.com > > Explainer https://github.com/rogerzanoni/docs/tree/main/lang-level-4 > > Specification https://www.w3.org/TR/selectors-4/#the-lang-pseudo > > Summary > > The :lang CSS pseudo-class currently mat

[blink-dev] Intent to Ship: CSS :lang pseudo class level 4

2023-03-16 Thread Roger Zanoni
Contact emails rzan...@igalia.com Explainer https://github.com/rogerzanoni/docs/tree/main/lang-level-4 Specification https://www.w3.org/TR/selectors-4/#the-lang-pseudo Summary The :lang CSS pseudo-class currently matches elements based on level 3 specs logic