Re: [blink-dev] Intent to Ship: CSS Root Font Units: 'rex', 'rch', 'ric', 'rlh'

2023-01-13 Thread Mike Taylor
LGTM3 On 1/13/23 10:28 AM, Rick Byers wrote: LGTM2 On Fri, Jan 13, 2023 at 10:12 AM Philip Jägenstedt wrote: I see, thanks for checking that! It’s worth checking that our test results match other browsers who have implemented, in case they can reveal different choices or interpr

Re: [blink-dev] Intent to Ship: CSS Root Font Units: 'rex', 'rch', 'ric', 'rlh'

2023-01-13 Thread Rick Byers
LGTM2 On Fri, Jan 13, 2023 at 10:12 AM Philip Jägenstedt wrote: > I see, thanks for checking that! It’s worth checking that our test results > match other browsers who have implemented, in case they can reveal > different choices or interpretations of the spec. > > LGTM1 > > On Thu, 12 Jan 2023

Re: [blink-dev] Intent to Ship: CSS Root Font Units: 'rex', 'rch', 'ric', 'rlh'

2023-01-13 Thread Philip Jägenstedt
I see, thanks for checking that! It’s worth checking that our test results match other browsers who have implemented, in case they can reveal different choices or interpretations of the spec. LGTM1 On Thu, 12 Jan 2023 at 16:54 Daniil Sakhapov wrote: > Safari has claimed to implement rlh, but no

Re: [blink-dev] Intent to Ship: CSS Root Font Units: 'rex', 'rch', 'ric', 'rlh'

2023-01-12 Thread 'Daniil Sakhapov' via blink-dev
Safari has claimed to implement rlh, but nothing else I guess. None of them are in Firefox. On Tue, Jan 10, 2023 at 11:11 AM Philip Jägenstedt wrote: > I see the Gecko issue has now been resolved as positive, which is great. > > Are any of these units already supported in Firefox or Safari, or w

Re: [blink-dev] Intent to Ship: CSS Root Font Units: 'rex', 'rch', 'ric', 'rlh'

2023-01-10 Thread Philip Jägenstedt
I see the Gecko issue has now been resolved as positive, which is great. Are any of these units already supported in Firefox or Safari, or would we be the first to ship all of them? (I took a look at one test and have a guess, but just as well to ask.) On Sat, 7 Jan 2023 at 01:48 Mike Taylor wro

Re: [blink-dev] Intent to Ship: CSS Root Font Units: 'rex', 'rch', 'ric', 'rlh'

2023-01-06 Thread Mike Taylor
On 1/5/23 5:07 AM, 'Daniil Sakhapov' via blink-dev wrote: Contact emails sakha...@chromium.org Specification https://www.w3.org/TR/css-values-4/#font-relative-lengths Summary Allows usage of root font units. Currently only 'rem' is supported in Blink. This featu

[blink-dev] Intent to Ship: CSS Root Font Units: 'rex', 'rch', 'ric', 'rlh'

2023-01-06 Thread 'Daniil Sakhapov' via blink-dev
Contact emailssakha...@chromium.org Specificationhttps://www.w3.org/TR/css-values-4/#font-relative-lengths Summary Allows usage of root font units. Currently only 'rem' is supported in Blink. This feature supports root element variants of ex, ch, ic, and lh too. Blink componentBlink>CSS