[blink-dev] Intent to Ship: CSS headline balancing

Contact emailsko...@chromium.org ExplainerNone Specification https://w3c.github.io/csswg-drafts/css-text-4/#valdef-text-wrap-balance Design docs https://docs.google.com/document/d/16-T9gqCagJxcST6hcnneSb7qGunxXa37_UHYqMqhPL0/edit?usp=sharing Summary Adjusts the lengths of lines in a paragraph

Re: [blink-dev] Intent to Ship: CSS headline balancing

I don't think this should ship until the relationship between white-space and text-wrap is fully resolved and implemented. That just seems like a bad idea. I don't think it will be difficult or time consuming, but I think it needs to be done. Also, as the editor of the spec, I'd also be intere

Re: [blink-dev] Intent to Ship: CSS headline balancing

On Tue, Feb 28, 2023 at 9:06 PM fantasai wrote: > I don't think this should ship until the relationship between white-space and > text-wrap is fully resolved and implemented. That just seems like a bad idea. > I don't think it will be difficult or time consuming, but I think it needs to > be do

Re: [blink-dev] Intent to Ship: CSS headline balancing

On 3/2/23 17:48, Tab Atkins Jr. wrote: On Tue, Feb 28, 2023 at 9:06 PM fantasai wrote: I don't think this should ship until the relationship between white-space and text-wrap is fully resolved and implemented. That just seems like a bad idea. I don't think it will be difficult or time consumi

Re: [blink-dev] Intent to Ship: CSS headline balancing

On Thu, Mar 2, 2023 at 6:59 PM fantasai wrote: > On 3/2/23 17:48, Tab Atkins Jr. wrote: > > If you think there are specific issues that need to be fixed (that > > don't equally need to be fixed for text-wrap:wrap), could you list > > them? > > The 'text-wrap' property is a longhand of 'white-space

Re: [blink-dev] Intent to Ship: CSS headline balancing

Hi Koji, Looks like the tests are in https://wpt.fyi/results/css/css-text/white-space?label=master&label=experimental&aligned&view=subtest&q=balance. There's one failing test there, do you know why that is? And overall, are you happy with the test coverage here, does it cover most important corner

Re: [blink-dev] Intent to Ship: CSS headline balancing

> > > This intent to ship just says that you will ship 'text-wrap'. It doesn't > say > > that you will also implement 'white-space-collapse' (the other longhand > of > > 'white-space') or the shorthanding relationship between 'text-wrap' and > > 'white-space'. I therefore assume you're shipping 'te

Re: [blink-dev] Intent to Ship: CSS headline balancing

On Mon, Mar 13, 2023 at 9:02 AM Koji Ishii wrote: > Looks like the tests are in >> https://wpt.fyi/results/css/css-text/white-space?label=master&label=experimental&aligned&view=subtest&q=balance. >> There's one failing test there, do you know why that is? > > > Thanks for pointing this out. The

Re: [blink-dev] Intent to Ship: CSS headline balancing

On Thu, Mar 16, 2023 at 12:51 AM Philip Jägenstedt wrote: > On Mon, Mar 13, 2023 at 9:02 AM Koji Ishii wrote: > > >> Looks like the tests are in >>> https://wpt.fyi/results/css/css-text/white-space?label=master&label=experimental&aligned&view=subtest&q=balance. >>> There's one failing test there

Re: [blink-dev] Intent to Ship: CSS headline balancing

On Wed, Mar 15, 2023 at 5:35 PM Koji Ishii wrote: > On Thu, Mar 16, 2023 at 12:51 AM Philip Jägenstedt > wrote: > >> On Mon, Mar 13, 2023 at 9:02 AM Koji Ishii wrote: >> >> >>> Looks like the tests are in https://wpt.fyi/results/css/css-text/white-space?label=master&label=experimental&alig

Re: [blink-dev] Intent to Ship: CSS headline balancing

LGTM1 On Mon, Mar 13, 2023 at 1:02 AM Koji Ishii wrote: > > This intent to ship just says that you will ship 'text-wrap'. It doesn't >> say >> > that you will also implement 'white-space-collapse' (the other longhand >> of >> > 'white-space') or the shorthanding relationship between 'text-wrap'

Re: [blink-dev] Intent to Ship: CSS headline balancing

LGTM2, it sounds like the compat risk described in https://github.com/w3c/csswg-drafts/issues/8398 prevents making the shorthand/longhand relationships exactly per spec, but that we're taking the same approach here as for baseline-source. On Thu, Mar 16, 2023 at 6:05 PM Chris Harrelson wrote: >

Re: [blink-dev] Intent to Ship: CSS headline balancing

On 3/13/23 04:02, Koji Ishii wrote: > This intent to ship just says that you will ship 'text-wrap'. It doesn't say > that you will also implement 'white-space-collapse' (the other longhand of > 'white-space') or the shorthanding relationship between 'text-wrap' and > 'whi

Re: [blink-dev] Intent to Ship: CSS headline balancing

On Fri, Mar 17, 2023 at 4:40 AM fantasai wrote: > That test doesn't cover the interaction of other values of `white-space` > with > the `nowrap` value of `text-wrap`. It would be incorrect for e.g. > `white-space: pre` to return `text-wrap: wrap`. > > I think it would be better to just implement

Re: [blink-dev] Intent to Ship: CSS headline balancing

LGTM3. - The shorthand issue can be addressed separately. - The maturity of the specification is a risk. But it seems the risk of behavior changes after shipping would be small. On Fri, Mar 17, 2023 at 3:03 PM Koji Ishii wrote: > On Fri, Mar 17, 2023 at 4:40 AM fantasai > wrote: > >> That t

Re: [blink-dev] Intent to Ship: CSS headline balancing

On 3/17/23 02:02, Koji Ishii wrote: On Fri, Mar 17, 2023 at 4:40 AM fantasai > wrote: That test doesn't cover the interaction of other values of `white-space` with the `nowrap` value of `text-wrap`. It would be incorrect for e.g. `white-space: p

Re: [blink-dev] Intent to Ship: CSS headline balancing

I am very supportive of this feature being worked on, but I am very puzzled by Google's intent to ship something that is different from the spec. It doesn't seem that you have expressed any disagreement with what the spec says, or asked for it to be changed. If you think the spec's design is wro

Re: [blink-dev] Intent to Ship: CSS headline balancing

On 3/21/23 13:53, Adam Argyle wrote: > I think it would be useful to know if you have positive feedback from web developers who have tried to incorporate it into actual designs Here's a few examples I've seen where not just developers getting excited about the single LOC they need to add for

Re: [blink-dev] Intent to Ship: CSS headline balancing

The reason we opted for the partially-implemented shorthand behaviour initially was the shorthand aspect of the specification appeared to be in an incomplete/unstable state. We've heard significant desire for the text-wrap:balance feature from web developers, and this analysis was based upon the sp

Re: [blink-dev] Intent to Ship: CSS headline balancing

On 3/23/23 18:41, Ian Kilpatrick wrote: Since sending this intent the specification for how the new shorthand works has changed significantly (for the better, thanks!). These were all pending edits. If I'd

Re: [blink-dev] Intent to Ship: CSS headline balancing

On Thu, Mar 23, 2023 at 3:41 PM Ian Kilpatrick wrote: > The reason we opted for the partially-implemented shorthand behaviour > initially was the shorthand aspect of the specification appeared to be in > an incomplete/unstable state. We've heard significant desire for the > text-wrap:balance feat