LGTM3
On Tue, May 14, 2024 at 8:49 AM Chris Harrelson
wrote:
> LGTM2
>
> On Mon, May 13, 2024 at 4:36 PM Mike Taylor
> wrote:
>
>> Hi Morten -
>>
>> Appreciate the response. I spent some time looking at
>>
LGTM2
On Mon, May 13, 2024 at 4:36 PM Mike Taylor wrote:
> Hi Morten -
>
> Appreciate the response. I spent some time looking at
> https://github.com/search?q=%22instanceof+CSSGroupingRule%22+language%3AJavaScript=code=JavaScript
> as well as "instanceof CSSRule" earlier, but didn't see
Hi Morten -
Appreciate the response. I spent some time looking at
https://github.com/search?q=%22instanceof+CSSGroupingRule%22+language%3AJavaScript=code=JavaScript
as well as "instanceof CSSRule" earlier, but didn't see anything
immediately worrying (granted, it's hard to predict perfectly
On Wed, 8 May 2024 at 17:18, Mike Taylor wrote:
> On 5/8/24 3:37 AM, Morten Stenshorne wrote:
>
> Interoperability and Compatibility
>
> Low risk. The one possible issue is if an author uses "instanceof
> CSSGroupingRule" or "instanceof CSSRule" with a page rule object and makes
> incorrect
On 5/8/24 3:37 AM, Morten Stenshorne wrote:
Interoperability and Compatibility
Low risk. The one possible issue is if an author uses "instanceof
CSSGroupingRule" or "instanceof CSSRule" with a page rule object and
makes incorrect assumptions based on that. However, given that this
Contact emailsmsten...@chromium.org
ExplainerNone
Specificationhttps://drafts.csswg.org/cssom/#the-csspagerule-interface
Summary
Let CSSPageRule inherit from CSSGroupingRule instead of CSSRule. The spec
[1] says that the CSSPageRule interface should inherit from
CSSGroupingRule, but Blink
