Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2022-03-22 Thread 3D PRINTERS ONLINE STORE LTD
Possibly this change affects our website slider gallery images breaking on page load. Please check this open bug : https://bugs.chromium.org/p/chromium/issues/detail?id=1291437 On Friday, December 24, 2021 at 12:11:57 PM UTC+5:30 mas...@chromium.org wrote: > Right, M99. Thanks Yuki, and sorr

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2022-03-21 Thread Mike Taylor
Your site isn't using adoptedStyleSheets, so it seems unlikely. But we can continue conversation in the bug. On 3/21/22 10:51 PM, 3D PRINTERS ONLINE STORE LTD wrote: Possibly this change affects our website slider gallery images breaking on page load. Please check this open bug : https://bug

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-23 Thread Mason Freed
Right, M99. Thanks Yuki, and sorry for the delay. On Thu, Dec 23, 2021 at 4:35 AM Yuki Shiino wrote: > 2021年12月22日(水) 5:03 'Joe Medley' via blink-dev : > >> Is this on 98? >> > > No, not in M98. > > > https://storage.googleapis.com/chromium-find-releases-static/e5b.html#e5b482aff3e9e0031527108c

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-23 Thread Yuki Shiino
2021年12月22日(水) 5:03 'Joe Medley' via blink-dev : > Is this on 98? > No, not in M98. https://storage.googleapis.com/chromium-find-releases-static/e5b.html#e5b482aff3e9e0031527108c7131861ed2640dcc says "Commit e5b482af... initially landed in 99.0.4761.0" so, I think this is in M99. > On Tuesday

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-21 Thread 'Joe Medley' via blink-dev
Is this on 98? On Tuesday, December 14, 2021 at 10:13:18 AM UTC-8 mas...@chromium.org wrote: > Thanks everyone! > > On Tue, Dec 14, 2021 at 9:59 AM Yoav Weiss wrote: > >> LGTM3 >> >> On Tue, Dec 14, 2021 at 4:12 PM Mike Taylor wrote: >> >>> LGTM2 >>> >>> On 12/14/21 10:05 AM, Camille Lamy wrot

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-14 Thread Mason Freed
Thanks everyone! On Tue, Dec 14, 2021 at 9:59 AM Yoav Weiss wrote: > LGTM3 > > On Tue, Dec 14, 2021 at 4:12 PM Mike Taylor > wrote: > >> LGTM2 >> >> On 12/14/21 10:05 AM, Camille Lamy wrote: >> >> Thanks Mason! I wasn't sure if it was possible to share it cross-origin, >> hence my question. If

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-14 Thread Yoav Weiss
LGTM3 On Tue, Dec 14, 2021 at 4:12 PM Mike Taylor wrote: > LGTM2 > > On 12/14/21 10:05 AM, Camille Lamy wrote: > > Thanks Mason! I wasn't sure if it was possible to share it cross-origin, > hence my question. If you can only get a non-shared copied version, then > this is fine from a security PO

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-14 Thread Mike Taylor
LGTM2 On 12/14/21 10:05 AM, Camille Lamy wrote: Thanks Mason! I wasn't sure if it was possible to share it cross-origin, hence my question. If you can only get a non-shared copied version, then this is fine from a security POV. On Tuesday, December 14, 2021 at 4:53:52 AM UTC+1 Mason Freed wro

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-14 Thread Camille Lamy
Thanks Mason! I wasn't sure if it was possible to share it cross-origin, hence my question. If you can only get a non-shared copied version, then this is fine from a security POV. On Tuesday, December 14, 2021 at 4:53:52 AM UTC+1 Mason Freed wrote: > Thanks Alex! I did file a TAG review for Obs

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-13 Thread Mason Freed
Thanks Alex! I did file a TAG review for ObservableArray and this first use by adoptedStyleSheets . No response yet. On Mon, Dec 13, 2021 at 4:03 PM Alex Russell wrote: > Thanks Mason, that matches my understanding of the situation too. > > Ca

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-13 Thread Alex Russell
Thanks Mason, that matches my understanding of the situation too. Can you please file an FYI with the TAG to let them know this new type is being put into use? It is often helpful for them to stay informed of new WebIDL primitives that they can suggest to others to help drive consistency. Sendi

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-08 Thread Mason Freed
Hi Camille, Thanks for the question. I guess I have two points/questions: 1. That sounds like a general question about adoptedStyleSheets (which we shipped a few years ago), and isn't at all particular to the conversion from FrozenArray to ObservableArray. But did I miss something relevant about t

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-07 Thread Camille Lamy
Hi Mason, We reviewed this intent in the S&P review today, and we were not quite clear on the scope of the change. In particular, is it possible for cross-origin documents to share the adoptedStyelSheets? If so, can a style sheet used across cross-origin documents be modified and the modificati

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-12-01 Thread Mason Freed
On Tue, Nov 30, 2021 at 8:40 AM Mason Freed wrote: > Was ObservableArray and its use in the web platform reviewed by the TAG? >> If not then I think it should be, as there are plans to use it in more >> places than just this. >> > > No, it wasn't. This is a good suggestion - I'll open a TAG revie

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-11-30 Thread Mason Freed
Thanks! On Mon, Nov 29, 2021 at 5:22 PM Chris Harrelson wrote: > > > On Mon, Nov 29, 2021 at 1:40 PM Mason Freed wrote: > >> >> TAG review >> >> TAG review statusNot applicable >> > > Was ObservableArray and its use in the web platform reviewed by the TAG? > If not then I think it should be, as

Re: [blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-11-29 Thread Chris Harrelson
On Mon, Nov 29, 2021 at 1:40 PM Mason Freed wrote: > Contact emailsmas...@chromium.org > > Explainer > https://developers.google.com/web/updates/2019/02/constructable-stylesheets > > Specification > https://www.w3.org/TR/cssom-1/#extensions-to-the-document-or-shadow-root-interface > > Summary > >

[blink-dev] Intent to Ship: Convert adoptedStyleSheets to use ObservableArray

2021-11-29 Thread Mason Freed
Contact emailsmas...@chromium.org Explainer https://developers.google.com/web/updates/2019/02/constructable-stylesheets Specification https://www.w3.org/TR/cssom-1/#extensions-to-the-document-or-shadow-root-interface Summary The prior specification for adoptedStyleSheets used a FrozenArray back