[blink-dev] Intent to Ship: Declarative shadow DOM serialization

2024-04-04 Thread Mason Freed
Contact emailsmas...@chromium.org Explainerhttps://github.com/whatwg/html/issues/8867#issuecomment-1856696628 Specificationhttps://html.spec.whatwg.org/#dom-element-gethtml Summary The prototype implementation (which was shipped in 2020 and then shape-changed in 2023) contained a method called

Re: [blink-dev] Intent to Ship: Declarative shadow DOM serialization

2024-04-04 Thread Alex Russell
Drive-by API design comments: Was this run past the TAG? Did they ask this is not adding a way to return a stream? And was there a discussion of a setter API that supports streams? It would be disappointing if we added new surface of this sort without resolving the core data type issues. Best, A

Re: [blink-dev] Intent to Ship: Declarative shadow DOM serialization

2024-04-05 Thread Vladimir Levin
On Thu, Apr 4, 2024 at 6:54 PM Mason Freed wrote: > Contact emailsmas...@chromium.org > > Explainer > https://github.com/whatwg/html/issues/8867#issuecomment-1856696628 > > Specificationhttps://html.spec.whatwg.org/#dom-element-gethtml > > Summary > > The prototype implementation (which was shipp

Re: [blink-dev] Intent to Ship: Declarative shadow DOM serialization

2024-04-05 Thread Mason Freed
Thanks for the comments! On Fri, Apr 5, 2024 at 8:26 AM Vladimir Levin wrote: > I think this is the case, but just to clarify: this is shipping a new > function and not renaming/updating the previously shipped one, right? So, > at least for the time being, there will be two similar functions shi

Re: [blink-dev] Intent to Ship: Declarative shadow DOM serialization

2024-04-10 Thread Alex Russell
Ok, so Chris reminded me that we'd already shipped a setter via `setHTMLUnsafe()` and that Mozilla has an intent out for this new version of the getter, which suggests to me that we should, indeed, handle the streams thing separately. LGTM1. On Friday, April 5, 2024 at 3:31:10 PM UTC-7 Mason F

Re: [blink-dev] Intent to Ship: Declarative shadow DOM serialization

2024-04-10 Thread Daniel Bratell
LGTM2 /Daniel On 2024-04-10 18:43, Alex Russell wrote: Ok, so Chris reminded me that we'd already shipped a setter via `setHTMLUnsafe()` and that Mozilla has an intent out for this new version of the getter, which suggests to me that we should, indeed, handle the streams thing separately. L

Re: [blink-dev] Intent to Ship: Declarative shadow DOM serialization

2024-04-10 Thread Mike Taylor
LGTM3 On 4/10/24 12:55 PM, Daniel Bratell wrote: LGTM2 /Daniel On 2024-04-10 18:43, Alex Russell wrote: Ok, so Chris reminded me that we'd already shipped a setter via `setHTMLUnsafe()` and that Mozilla has an intent out for this new version of the getter, which suggests to me that we shoul

Re: [blink-dev] Intent to Ship: Declarative shadow DOM serialization

2024-04-10 Thread Mason Freed
Thank you all! Mason On Wed, Apr 10, 2024 at 11:27 AM Mike Taylor wrote: > LGTM3 > On 4/10/24 12:55 PM, Daniel Bratell wrote: > > LGTM2 > > /Daniel > On 2024-04-10 18:43, Alex Russell wrote: > > Ok, so Chris reminded me that we'd already shipped a setter via > `setHTMLUnsafe()` and that Mozill