Re: [blink-dev] Intent to Ship: Extension of WebDriver command for clicking on FedCM dialogs

2023-12-07 Thread Philip Jägenstedt
LGTM3 On Tue, Dec 5, 2023 at 7:58 PM Rick Byers wrote: > LGTM2 > > On Tue, Dec 5, 2023 at 12:31 PM Mike Taylor > wrote: > >> LGTM1 >> On 12/5/23 3:44 AM, 'Zachary Tan' via blink-dev wrote: >> >> My mistake - it is indeed without the "k", thanks for double checking. >> >> On Tue, Dec 5, 2023 at

Re: [blink-dev] Intent to Ship: Extension of WebDriver command for clicking on FedCM dialogs

2023-12-05 Thread Rick Byers
LGTM2 On Tue, Dec 5, 2023 at 12:31 PM Mike Taylor wrote: > LGTM1 > On 12/5/23 3:44 AM, 'Zachary Tan' via blink-dev wrote: > > My mistake - it is indeed without the "k", thanks for double checking. > > On Tue, Dec 5, 2023 at 5:34 PM Domenic Denicola > wrote: > >> >> >> On Tue, Dec 5, 2023 at

Re: [blink-dev] Intent to Ship: Extension of WebDriver command for clicking on FedCM dialogs

2023-12-05 Thread Mike Taylor
LGTM1 On 12/5/23 3:44 AM, 'Zachary Tan' via blink-dev wrote: My mistake - it is indeed without the "k", thanks for double checking. On Tue, Dec 5, 2023 at 5:34 PM Domenic Denicola wrote: On Tue, Dec 5, 2023 at 3:42 PM 'Zachary Tan' via blink-dev wrote: Contact

Re: [blink-dev] Intent to Ship: Extension of WebDriver command for clicking on FedCM dialogs

2023-12-05 Thread 'Zachary Tan' via blink-dev
My mistake - it is indeed without the "k", thanks for double checking. On Tue, Dec 5, 2023 at 5:34 PM Domenic Denicola wrote: > > > On Tue, Dec 5, 2023 at 3:42 PM 'Zachary Tan' via blink-dev < > blink-dev@chromium.org> wrote: > >> Contact emails >> >> tanzach...@chromium.org >> >> Explainer >>

Re: [blink-dev] Intent to Ship: Extension of WebDriver command for clicking on FedCM dialogs

2023-12-05 Thread Domenic Denicola
On Tue, Dec 5, 2023 at 3:42 PM 'Zachary Tan' via blink-dev < blink-dev@chromium.org> wrote: > Contact emails > > tanzach...@chromium.org > > Explainer > > None > > Specification > > https://github.com/fedidcg/FedCM/pull/510 > > Design docs > > None > > Summary > > This changes one of our existing

[blink-dev] Intent to Ship: Extension of WebDriver command for clicking on FedCM dialogs

2023-12-04 Thread 'Zachary Tan' via blink-dev
Contact emails tanzach...@chromium.org Explainer None Specification https://github.com/fedidcg/FedCM/pull/510 Design docs None Summary This changes one of our existing WebDriver commands to allow clicking on a button on the FedCM dialog by passing a parameter of the button to click rather