Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

Back to the original intent, the only outstanding question I see is the status of the WPTs. I see the CL has added 4 WPTs

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

You got it right! And no, there's no need for the heavier-weight about:flags for these sorts of small changes. On Thu, Sep 4, 2025 at 1:04 AM Helmut Januschka wrote: > so it is a FinchFlag `ModulePreloadReferrer` and it is not listed in > about_flags.cc - hope i filled out the correct field in

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

so it is a FinchFlag `ModulePreloadReferrer` and it is not listed in about_flags.cc - hope i filled out the correct field in chromestatus should it be listed in about_flags for webdevs to enable? Daniel Bratell schrieb am Mittwoch, 3. September 2025 um 17:17:28 UTC+2: > Great! > > Can you plea

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

Great! Can you please add the flag to appropriate field in the feature's chromestatus entry so that people can find the flag if needed? /Daniel On 2025-09-02 20:30, Helmut Januschka wrote: It's relanded now with a feature flag! Thanks to everyone involved, and sorry for the troubles! Helmu

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

It's relanded now with a feature flag! Thanks to everyone involved, and sorry for the troubles! Helmut Januschka schrieb am Dienstag, 2. September 2025 um 11:00:20 UTC+2: > the revert was back-merged into 140, and i am working on a reland here: > http://crrev.com/c/6898599 with feature flag aro

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

the revert was back-merged into 140, and i am working on a reland here: http://crrev.com/c/6898599 with feature flag around the change. yoav...@chromium.org schrieb am Freitag, 29. August 2025 um 05:40:48 UTC+2: > On Thu, Aug 28, 2025 at 10:25 PM Krishna Govind wrote: > >> Thank you, any impact

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

On Thu, Aug 28, 2025 at 10:25 PM Krishna Govind wrote: > Thank you, any impact on Android Webview? Will it be safe to merge the > revert? > Yeah, it will impact Android WebViews as well. (but is safe to merge) > > Merged the revert to latest canary branch 7381 and triggered a new canary > #141

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

Thank you, any impact on Android Webview? Will it be safe to merge the revert? Merged the revert to latest canary branch 7381 and triggered a new canary #141.0.7381.3, please verify once available, will approve M140 merge after canary coverage/verification. Updated the bugs: - https://g-issue

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

Merge request issue is at https://issues.chromium.org/issues/441770546 CL is at https://chromium-review.googlesource.com/c/chromium/src/+/6897886 On Thu, Aug 28, 2025 at 9:37 PM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > > > On Thu, Aug 28, 2025 at 6:21 PM 'Krishna Govind' via blink

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

On Thu, Aug 28, 2025 at 6:21 PM 'Krishna Govind' via blink-dev < blink-dev@chromium.org> wrote: > Hi Mike, > > Thank you for including Srinivas and me in this discussion. > > Since M140 was released to early stable yesterday with this feature > enabled by default and without all necessary approval

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

again, super sorry, this might be the single worst chromium day i had since my first contribution. tried to fillout everything in chromestatus entry, and request all the reviews again. a revert CL is here: https://chromium-review.googlesource.com/c/chromium/src/+/6895357 ready to review/submit. j

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

revert landet! the post mortem from my side: totally my fault, i saw the CR+1's and the Submit button, forgot about the not finished chromestatus feature entry Krishna Govind schrieb am Donnerstag, 28. August 2025 um 18:26:35 UTC+2: > +Ben Mason for awareness and visibility > > On Thu, Aug 28

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

+Ben Mason for awareness and visibility On Thu, Aug 28, 2025 at 9:21 AM Krishna Govind wrote: > Hi Mike, > > Thank you for including Srinivas and me in this discussion. > > Since M140 was released to early stable yesterday with this feature > enabled by default and without all necessary approva

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

Hi Mike, Thank you for including Srinivas and me in this discussion. Since M140 was released to early stable yesterday with this feature enabled by default and without all necessary approvals, it's critical that we merge the revert to M140 and recut the M140 Stable RC for release on Tuesday, Sept

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

Thanks Helmet - please don't be too hard on yourself. We've all been there. :) For now, I would recommend getting the revert landed and requesting a merge into beta. Thanks for requesting the other reviews. On 8/28/25 5:36 p.m., Helmut Januschka wrote: again, super sorry, this might be the si

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

Hey Helmut, Oops. It's unfortunate that this feature is missing Privacy, Security, Enterprise, Debuggability & Testing reviews (per Chris' request back in May)... but I think more concerning is the fact that it's not guarded behind a feature flag. If we do end up breaking some sites (the risk

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

Hi all, I mistakenly landed the [CL](https://chromium-review.googlesource.com/c/chromium/src/+/6509110) in M140 before getting the intent to ship approved. My apologies for that. I'd appreciate guidance on how to proceed, given that. One way to go would be to keep the CL landed, and get your a

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

Please also fill out the Privacy, Security, Enterprise, Debuggability and Testing sections in the chromestatus entry. On Tue, May 13, 2025 at 9:51 PM Domenic Denicola wrote: > > > On Wed, May 14, 2025 at 5:10 AM Chromestatus < > ad...@cr-status.appspotmail.com> wrote: > >> Contact emails hjanusc

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

On Wed, May 14, 2025 at 5:10 AM Chromestatus < ad...@cr-status.appspotmail.com> wrote: > Contact emails hjanusc...@gmail.com > > Explainer None > > Specification > https://html.spec.whatwg.org/multipage/links.html#link-type-modulepreload:script-fetch-options > > Summary > > Fixes modulepreload to

[blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

Contact emails hjanusc...@gmail.com Explainer None Specification https://html.spec.whatwg.org/multipage/links.html#link-type-modulepreload:script-fetch-options Summary Fixes modulepreload to properly send referrer headers by using ClientReferrerString() instead of NoReferrer(). This aligns