Re: [blink-dev] Intent to Ship: Protected Audience - Fix implementation and spec for renderSize

2024-06-12 Thread Chris Harrelson
LGTM3 On Wed, Jun 12, 2024 at 4:06 PM Daniel Bratell wrote: > LGTM2 > > /Daniel > On 2024-06-12 13:09, Yoav Weiss (@Shopify) wrote: > > LGTM1 > > This sounds like a web-exposed bug fix, and I agree that the risk seems > low. > > On Tue, Jun 11, 2024 at 6:10 PM 'Xiaochen Zhou' via blink-dev < > b

Re: [blink-dev] Intent to Ship: Protected Audience - Fix implementation and spec for renderSize

2024-06-12 Thread Daniel Bratell
LGTM2 /Daniel On 2024-06-12 13:09, Yoav Weiss (@Shopify) wrote: LGTM1 This sounds like a web-exposed bug fix, and I agree that the risk seems low. On Tue, Jun 11, 2024 at 6:10 PM 'Xiaochen Zhou' via blink-dev wrote: I have started the requests, thank you. This item was originated

Re: [blink-dev] Intent to Ship: Protected Audience - Fix implementation and spec for renderSize

2024-06-12 Thread Yoav Weiss (@Shopify)
LGTM1 This sounds like a web-exposed bug fix, and I agree that the risk seems low. On Tue, Jun 11, 2024 at 6:10 PM 'Xiaochen Zhou' via blink-dev < blink-dev@chromium.org> wrote: > I have started the requests, thank you. This item was originated from a > previous launch: > https://chromestatus.co

Re: [blink-dev] Intent to Ship: Protected Audience - Fix implementation and spec for renderSize

2024-06-11 Thread 'Xiaochen Zhou' via blink-dev
I have started the requests, thank you. This item was originated from a previous launch: https://chromestatus.com/feature/5140606359175168?gate=5143092244250624. This feature was added to the Protected Audience explainer, but was never implemented or spec'd. This launch implemented this missing

Re: [blink-dev] Intent to Ship: Protected Audience - Fix implementation and spec for renderSize

2024-06-11 Thread Vladimir Levin
Hi, Can you please start the various reviews in chromestatus? [image: chipsna.png] Thanks, Vlad On Fri, Jun 7, 2024 at 11:10 AM 'Xiaochen Zhou' via blink-dev < blink-dev@chromium.org> wrote: > Contact emails > > xiaoche...@google.com, shivani...@google.com, jkar...@google.com > > Explainer > >

[blink-dev] Intent to Ship: Protected Audience - Fix implementation and spec for renderSize

2024-06-07 Thread 'Xiaochen Zhou' via blink-dev
Contact emails xiaoche...@google.com, shivani...@google.com, jkar...@google.com Explainer https://github.com/WICG/turtledove/pull/1145 Specification https://github.com/WICG/turtledove/pull/1141 Design docs https://docs.google.com/document/d/1JSUZzEnVGn6Rz6ncLbyhThModoxTGnBn-jS5xJf4Aq0/edit?u