Re: [blink-dev] Intent to Ship: RegExp duplicate named capture groups

2024-03-13 Thread Daniel Bratell
LGTM3 /Daniel On 2024-03-11 17:16, Yoav Weiss (@Shopify) wrote: LGTM2 On Mon, Mar 11, 2024 at 5:00 PM Shu-yu Guo wrote: On Mon, Mar 11, 2024 at 8:26 AM Mike Taylor wrote: On 3/11/24 6:49 AM, Yoav Weiss (@Shopify) wrote: On Fri, Mar 8, 2024 at 4:26 PM Mike

Re: [blink-dev] Intent to Ship: RegExp duplicate named capture groups

2024-03-11 Thread Yoav Weiss (@Shopify)
LGTM2 On Mon, Mar 11, 2024 at 5:00 PM Shu-yu Guo wrote: > On Mon, Mar 11, 2024 at 8:26 AM Mike Taylor > wrote: > >> On 3/11/24 6:49 AM, Yoav Weiss (@Shopify) wrote: >> >> >> >> On Fri, Mar 8, 2024 at 4:26 PM Mike Taylor >> wrote: >> >>> LGTM1 >>> On 3/7/24 6:22 PM, Shu-yu Guo wrote: >>> >>>

Re: [blink-dev] Intent to Ship: RegExp duplicate named capture groups

2024-03-11 Thread Shu-yu Guo
On Mon, Mar 11, 2024 at 8:26 AM Mike Taylor wrote: > On 3/11/24 6:49 AM, Yoav Weiss (@Shopify) wrote: > > > > On Fri, Mar 8, 2024 at 4:26 PM Mike Taylor wrote: > >> LGTM1 >> On 3/7/24 6:22 PM, Shu-yu Guo wrote: >> >> Contact emails pth...@chromium.org, s...@chromium.org >> >> Explainer None >>

Re: [blink-dev] Intent to Ship: RegExp duplicate named capture groups

2024-03-11 Thread Mike Taylor
On 3/11/24 6:49 AM, Yoav Weiss (@Shopify) wrote: On Fri, Mar 8, 2024 at 4:26 PM Mike Taylor wrote: LGTM1 On 3/7/24 6:22 PM, Shu-yu Guo wrote: Contact emails pth...@chromium.org, s...@chromium.org Explainer None Specification

Re: [blink-dev] Intent to Ship: RegExp duplicate named capture groups

2024-03-11 Thread Yoav Weiss (@Shopify)
On Fri, Mar 8, 2024 at 4:26 PM Mike Taylor wrote: > LGTM1 > On 3/7/24 6:22 PM, Shu-yu Guo wrote: > > Contact emails pth...@chromium.org, s...@chromium.org > > Explainer None > > Specification https://github.com/tc39/ecma262/pull/2721 > > What are the implications of this on regexes that already

Re: [blink-dev] Intent to Ship: RegExp duplicate named capture groups

2024-03-08 Thread Mike Taylor
LGTM1 On 3/7/24 6:22 PM, Shu-yu Guo wrote: Contact emails pth...@chromium.org, s...@chromium.org Explainer None Specification https://github.com/tc39/ecma262/pull/2721 Summary https://github.com/tc39/proposal-duplicate-named-capturing-groups

[blink-dev] Intent to Ship: RegExp duplicate named capture groups

2024-03-07 Thread Shu-yu Guo
Contact emailspth...@chromium.org, s...@chromium.org ExplainerNone Specificationhttps://github.com/tc39/ecma262/pull/2721 Summary https://github.com/tc39/proposal-duplicate-named-capturing-groups Blink componentBlink>JavaScript>Regexp