Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-19 Thread Rick Byers
Thanks for the update and coordination with Mozilla David! Rick On Mon, Apr 17, 2023 at 12:09 PM David Awogbemila wrote: > A quick update here: > I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1827975 with mozilla > about the keyboard issue and they seem to agree on the behavior being >

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-17 Thread David Awogbemila
A quick update here: I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1827975 with mozilla about the keyboard issue and they seem to agree on the behavior being tested, i.e. "if no scrolling happened, don't fire scrollend", so I think they'll look into that bug on their end. I've also commented

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-12 Thread Chris Harrelson
On Wed, Apr 12, 2023 at 8:34 AM Alex Russell wrote: > Regardless of the LGTM's, it's not sufficient to cite a CSS WG draft. > Please advise the TAG with an FYI before you ship. > Hi Alex, In this case I think a TAG review is not necessary for the reason

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-12 Thread Alex Russell
Regardless of the LGTM's, it's not sufficient to cite a CSS WG draft. Please advise the TAG with an FYI before you ship. On Wednesday, April 12, 2023 at 8:20:44 AM UTC-7 Daniel Bratell wrote: > LGTM3 > > /Daniel > On 2023-04-12 10:57, Yoav Weiss wrote: > > Thanks for verifying this and for filin

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-12 Thread Daniel Bratell
LGTM3 /Daniel On 2023-04-12 10:57, Yoav Weiss wrote: Thanks for verifying this and for filing Firefox issues. LGTM2 On Tue, Apr 11, 2023 at 10:46 PM David Awogbemila wrote: On Fri, Apr 7, 2023 at 4:49 AM Yoav Weiss wrote: On Thu, Apr 6, 2023 at 2:39 AM David Awogbemi

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-12 Thread Yoav Weiss
Thanks for verifying this and for filing Firefox issues. LGTM2 On Tue, Apr 11, 2023 at 10:46 PM David Awogbemila wrote: > > > On Fri, Apr 7, 2023 at 4:49 AM Yoav Weiss wrote: > >> >> >> On Thu, Apr 6, 2023 at 2:39 AM David Awogbemila >> wrote: >> >>> >>> >>> On Wed, Apr 5, 2023 at 12:11 AM Yo

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-11 Thread David Awogbemila
On Fri, Apr 7, 2023 at 4:49 AM Yoav Weiss wrote: > > > On Thu, Apr 6, 2023 at 2:39 AM David Awogbemila > wrote: > >> >> >> On Wed, Apr 5, 2023 at 12:11 AM Yoav Weiss >> wrote: >> >>> >>> >>> On Fri, Mar 31, 2023 at 3:50 PM David Awogbemila < >>> awogbem...@chromium.org> wrote: >>> Contact

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-07 Thread Yoav Weiss
On Thu, Apr 6, 2023 at 2:39 AM David Awogbemila wrote: > > > On Wed, Apr 5, 2023 at 12:11 AM Yoav Weiss wrote: > >> >> >> On Fri, Mar 31, 2023 at 3:50 PM David Awogbemila >> wrote: >> >>> Contact emails >>> arg...@google.com, awogbem...@google.com >>> >>> Explainer >>> https://github.com/argyle

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-06 Thread Rick Byers
Thanks for the WPT failure investigation and work to get them passing. LGTM1 once they pass. I'm excited to see this ship! On Wed, Apr 5, 2023 at 8:40 PM David Awogbemila wrote: > > > On Wed, Apr 5, 2023 at 11:24 AM Alex Russell > wrote: > >> Also, was this send to the TAG? >> > No this wasn't

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-05 Thread David Awogbemila
On Wed, Apr 5, 2023 at 11:24 AM Alex Russell wrote: > Also, was this send to the TAG? > No this wasn't sent to the TAG since scrollend is already included in the working group specification on scrolling ( https://drafts.csswg.org/cssom-view/#scrolling-events) and it has already shipped in Firefox

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-05 Thread David Awogbemila
On Wed, Apr 5, 2023 at 12:11 AM Yoav Weiss wrote: > > > On Fri, Mar 31, 2023 at 3:50 PM David Awogbemila > wrote: > >> Contact emails >> arg...@google.com, awogbem...@google.com >> >> Explainer >> https://github.com/argyleink/scrollend-explainer/blob/main/README.md >> > > The explainer says this

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-05 Thread Alex Russell
Also, was this send to the TAG? On Tuesday, April 4, 2023 at 9:11:26 PM UTC-7 Yoav Weiss wrote: > On Fri, Mar 31, 2023 at 3:50 PM David Awogbemila > wrote: > >> Contact emails >> arg...@google.com, awogbem...@google.com >> >> Explainer >> https://github.com/argyleink/scrollend-explainer/blob/ma

Re: [blink-dev] Intent to Ship: Scrollend Event

2023-04-04 Thread Yoav Weiss
On Fri, Mar 31, 2023 at 3:50 PM David Awogbemila wrote: > Contact emails > arg...@google.com, awogbem...@google.com > > Explainer > https://github.com/argyleink/scrollend-explainer/blob/main/README.md > The explainer says this shipped in 114. I guess it should say y'all are expecting to ship at

[blink-dev] Intent to Ship: Scrollend Event

2023-03-31 Thread David Awogbemila
Contact emails arg...@google.com, awogbem...@google.com Explainer https://github.com/argyleink/scrollend-explainer/blob/main/README.md Specificationhttps://drafts.csswg.org/cssom-view/#scrolling-events Summary Scrollend events help developers reliably tell when a scroll has completed (including