Re: [blink-dev] Intent to Ship: Update the syntax of `text-wrap` to match the new spec

2024-08-21 Thread Daniel Bratell
LGTM3 /Daniel On 2024-08-21 17:52, Mike Taylor wrote: LGTM2 On 8/21/24 5:52 PM, Alex Russell wrote: LGTM1 On Tuesday, August 20, 2024 at 12:05:14 AM UTC-7 Koji Ishii wrote: Thank you for pointing this out, Demenic. Will there be any compatibility issues, i.e. code that means

Re: [blink-dev] Intent to Ship: Update the syntax of `text-wrap` to match the new spec

2024-08-21 Thread Mike Taylor
LGTM2 On 8/21/24 5:52 PM, Alex Russell wrote: LGTM1 On Tuesday, August 20, 2024 at 12:05:14 AM UTC-7 Koji Ishii wrote: Thank you for pointing this out, Demenic. Will there be any compatibility issues, i.e. code that means something different before and after the change?

Re: [blink-dev] Intent to Ship: Update the syntax of `text-wrap` to match the new spec

2024-08-21 Thread Alex Russell
LGTM1 On Tuesday, August 20, 2024 at 12:05:14 AM UTC-7 Koji Ishii wrote: > Thank you for pointing this out, Demenic. > > Will there be any compatibility issues, i.e. code that means something >> different before and after the change? > > > You're right, there will be. The `balance` and `pretty`

Re: [blink-dev] Intent to Ship: Update the syntax of `text-wrap` to match the new spec

2024-08-20 Thread Koji Ishii
Thank you for pointing this out, Demenic. Will there be any compatibility issues, i.e. code that means something > different before and after the change? You're right, there will be. The `balance` and `pretty` are valid for the `text-wrap` property, before or after this change, but they are no l

Re: [blink-dev] Intent to Ship: Update the syntax of `text-wrap` to match the new spec

2024-08-19 Thread Domenic Denicola
On Tue, Aug 20, 2024 at 1:59 PM Koji Ishii wrote: > Contact emailsko...@chromium.org > > ExplainerNone > > Specificationhttps://drafts.csswg.org/css-text-4/#text-wrap-shorthand > > Design docs > > https://docs.google.com/document/d/1Xl3J1WCg--fUm1-FX5gHbJIIC0szNwulQV7nW4n6_aY/edit?usp=sharing > >

[blink-dev] Intent to Ship: Update the syntax of `text-wrap` to match the new spec

2024-08-19 Thread Koji Ishii
Contact emailsko...@chromium.org ExplainerNone Specificationhttps://drafts.csswg.org/css-text-4/#text-wrap-shorthand Design docs https://docs.google.com/document/d/1Xl3J1WCg--fUm1-FX5gHbJIIC0szNwulQV7nW4n6_aY/edit?usp=sharing Summary Updates the CSS syntax for the CSS white-space and text-wrap